[3005] in BarnOwl Developers
Re: Thoughts on our current code review policy
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Thu Mar 24 03:14:37 2011
Date: Thu, 24 Mar 2011 03:14:33 -0400 (EDT)
From: Anders Kaseorg <andersk@MIT.EDU>
To: Nelson Elhage <nelhage@nelhage.com>
cc: barnowl-dev@mit.edu
In-Reply-To: <AANLkTimpiLgdAo=YHtZMxctP_R7YK-LPEdtG3F+TFpbw@mail.gmail.com>
On Wed, 23 Mar 2011, Nelson Elhage wrote:
> And so largely code review ends up just nitpicking on style and other=20
> local issues, that, while not irrelevant, also just don't matter all=20
> that much.
BTW, at least when I review code, the style comments are produced as a=20
byproduct of reading and understanding the code well enough to check it=20
for more global issues. I don=E2=80=99t think there=E2=80=99s anything wro=
ng with a=20
review that consists entirely of style nitpicking if, in fact, style is=20
the only problem.
Anders
