[3004] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

Re: [PATCH] Clean up owl_keypress_tostring to return a newly-allocated

daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Thu Mar 24 03:08:28 2011

Date: Thu, 24 Mar 2011 03:08:24 -0400 (EDT)
From: Anders Kaseorg <andersk@MIT.EDU>
To: David Benjamin <davidben@mit.edu>
cc: barnowl-dev@mit.edu
In-Reply-To: <1299857479-5506-1-git-send-email-davidben@mit.edu>

On Fri, 11 Mar 2011, David Benjamin wrote:
> -  char keypress[64];  /* TODO: don't hard-code a value here. */
> +  char *keypress;

You could scope that to the for loop below.

LGTM.

Anders

home help back first fref pref prev next nref lref last post