[3006] in BarnOwl Developers
Re: [PATCH] Normalize class names to NFKC when logging
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Thu Mar 24 03:36:20 2011
Date: Thu, 24 Mar 2011 03:36:15 -0400 (EDT)
From: Anders Kaseorg <andersk@MIT.EDU>
To: David Benjamin <davidben@mit.edu>
cc: barnowl-dev@mit.edu
In-Reply-To: <1292381868-25922-1-git-send-email-davidben@mit.edu>
On Tue, 14 Dec 2010, David Benjamin wrote:
> + /* Class names are normalized to NFKC */
> + from =3D frombuff =3D g_utf8_normalize(owl_message_get_class(m), -=
1, G_NORMALIZE_NFKC);
> =E2=80=A6
> char* temp =3D g_utf8_strdown(frombuff, -1);
The Zephyr server does case folding rather than downcasing (so, for=20
example, =C3=9F goes to ss). Furthermore, it does so before normalization=
=20
rather than after (which maybe makes a difference in crazy corner cases? =
=20
I don=E2=80=99t really know).
I note that we probably have other NFKC-related bugs, such as when=20
narrowing and when maintaining the subs file.
Anders
