[3003] in BarnOwl Developers
Re: [PATCH] Punt a number of g_new NULL checks, various minor
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Thu Mar 24 03:04:30 2011
Date: Thu, 24 Mar 2011 03:04:27 -0400 (EDT)
From: Anders Kaseorg <andersk@MIT.EDU>
To: David Benjamin <davidben@mit.edu>
cc: barnowl-dev@mit.edu
In-Reply-To: <1299821253-2657-1-git-send-email-davidben@mit.edu>
On Fri, 11 Mar 2011, David Benjamin wrote:
> No real need to check g_new's return value as it always succeeds. (Or
> destroys the universe^Wprocess in embarrassment.) Also make owl_global
> manage the lifetime of the kill buffer since it's part of owl_global
> now. And replace a g_new/strncpy with a g_strndup. It's shorter.
LGTM.
Anders
