[3002] in BarnOwl Developers
Re: [PATCH 2/2] Don't pass limited buffer lengths to
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Thu Mar 24 02:59:45 2011
Date: Thu, 24 Mar 2011 02:59:42 -0400 (EDT)
From: Anders Kaseorg <andersk@MIT.EDU>
To: David Benjamin <davidben@mit.edu>
cc: barnowl-dev@mit.edu
In-Reply-To: <1299790123-17519-2-git-send-email-davidben@mit.edu>
On Thu, 10 Mar 2011, David Benjamin wrote:
> /* returns 0 on success */
> -int owl_keybinding_stack_tostring(int *j, int len, char *buff, int buffl=
en)
> +char *owl_keybinding_stack_tostring(int *j, int len)
> /* returns 0 on success */
> -int owl_keybinding_tostring(const owl_keybinding *kb, char *buff, int bu=
fflen)
> +char *owl_keybinding_tostring(const owl_keybinding *kb)
The comments are wrong now.
> + char keypress[64]; /* TODO: don't hard-code a value here. */
Fine, but only since it=E2=80=99s going away a few commits later. :-P
Anders
