[517] in SIPB_Linux_Development
runACT(), file_exists check is *backwards*
daemon@ATHENA.MIT.EDU ("Mark W. Eichin")
Sun Mar 13 11:50:12 1994
Date: Sun, 13 Mar 94 11:49:53 EST
From: eichin@MIT.EDU ("Mark W. Eichin")
To: linux-dev@MIT.EDU
In this block of code (around line 980 or so, quiche:/usr/src/athena/xdm/xlogin/xlogin.c):
/* wait for activation to finish */
if (activation_state != ACTIVATED)
fprintf(stderr, "Waiting for workstation to finish activating...\n");
while (activation_state != ACTIVATED)
sigpause(0);
if (file_exists (resources.srvdcheck)) {
fprintf(stderr, "Workstation failed to activate successfully.");
return;
The "file_exists" check is *backwards*. In particular, note that the
original athena sources (/source/athena/athena.etc/xdm/xlogin/xlogin.c,
line 978) says:
if (access(resources.srvdcheck, F_OK) != 0) {
which means "do this if the file is *not* accessible"...
The upshot of this is that any of the "Other Options" selections fail
immediately with a "Workstation failed to activate successfully."
If someone gets a chance to fix this and rebuild and repackage, please
let "Yonah Schmeidler" <yonah> know, as he's the one that pointed it out.
_Mark_
