[27252] in Source-Commits
python-discuss commit: Make automaic retry on EINTR actually work
daemon@ATHENA.MIT.EDU (Victor Vasiliev)
Sun Sep 1 14:51:39 2013
Date: Sun, 1 Sep 2013 14:51:30 -0400
From: Victor Vasiliev <vasilvv@MIT.EDU>
Message-Id: <201309011851.r81IpUhA017948@drugstore.mit.edu>
To: source-commits@MIT.EDU
https://github.com/mit-athena/python-discuss/commit/53dab3ce73ab137b90cd95ac9e52da99ee6cbbc1
commit 53dab3ce73ab137b90cd95ac9e52da99ee6cbbc1
Author: Victor Vasiliev <vasilvv@mit.edu>
Date: Sun Sep 1 14:47:03 2013 -0400
Make automaic retry on EINTR actually work
I have tested that before, but apparently when I was testing this code I
hit one of those random cases where EINTR is not triggered despite me
actively resizing the window on the loading screen. I hate signals.
discuss/rpc.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/discuss/rpc.py b/discuss/rpc.py
index d9db5a9..7c1532f 100644
--- a/discuss/rpc.py
+++ b/discuss/rpc.py
@@ -285,7 +285,7 @@ class RPCClient(object):
return self.socket.recv(*args, **kwargs)
except socket.error as err:
if err.errno == errno.EINTR:
- self2.recv(*arg, **kwargs)
+ return self2.recv(*args, **kwargs)
else:
raise err
@@ -294,7 +294,7 @@ class RPCClient(object):
return self.socket.sendall(*args, **kwargs)
except socket.error as err:
if err.errno == errno.EINTR:
- self2.sendall(*arg, **kwargs)
+ return self2.sendall(*args, **kwargs)
else:
raise err
