[27251] in Source-Commits
Re: discuss commit: Fix segmentation fault on listing transactions
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Sun Aug 25 18:06:33 2013
Date: Sun, 25 Aug 2013 18:06:23 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Alex Chernyakhovsky <achernya@MIT.EDU>
cc: Anders Kaseorg <andersk@MIT.EDU>,
"source-commits@mit.edu" <source-commits@MIT.EDU>
In-Reply-To: <CAB18ysqkyOvhH=1SGkN2g-cK3A6xyAwiyiUVk=393YL5_nO4Fg@mail.gmail.com>
Message-ID: <alpine.GSO.1.10.1308251806090.24720@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
That sounds good to me.
-Ben
On Sun, 25 Aug 2013, Alex Chernyakhovsky wrote:
> Jon and I definitely discussed this---the workflow we envision getting
> to is that a developer:
> * forks the repository on github, making some changes
> * the developer submits a pull request
> * a different debathena developer approves the changes and pushes
> them to drugstore, rebasing as needed.
>
> Sincerely,
> -Alex
>
>
> On Sun, Aug 25, 2013 at 2:30 PM, Anders Kaseorg <andersk@mit.edu> wrote:
>> On Sun, 25 Aug 2013, Jonathan Reed wrote:
>>> I don't love the fix, but I also don't love anything else in the Discuss
>>> code.
>>
>> So, as I mentioned on Zephyr, strdup("").
>>
>> Now that we have the technology, what do we think about replacing the
>> post-commit review period with an equivalent pre-commit review period?
>>
>> Anders
>