[27253] in Source-Commits
Re: python-discuss commit: Make automaic retry on EINTR actually
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Sun Sep 1 17:39:33 2013
Date: Sun, 1 Sep 2013 17:39:24 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Victor Vasiliev <vasilvv@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201309011851.r81IpUhA017948@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1309011739200.16692@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
ACK.
-Ben
On Sun, 1 Sep 2013, Victor Vasiliev wrote:
> https://github.com/mit-athena/python-discuss/commit/53dab3ce73ab137b90cd95ac9e52da99ee6cbbc1
> commit 53dab3ce73ab137b90cd95ac9e52da99ee6cbbc1
> Author: Victor Vasiliev <vasilvv@mit.edu>
> Date: Sun Sep 1 14:47:03 2013 -0400
>
> Make automaic retry on EINTR actually work
>
> I have tested that before, but apparently when I was testing this code I
> hit one of those random cases where EINTR is not triggered despite me
> actively resizing the window on the loading screen. I hate signals.
>
> discuss/rpc.py | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/discuss/rpc.py b/discuss/rpc.py
> index d9db5a9..7c1532f 100644
> --- a/discuss/rpc.py
> +++ b/discuss/rpc.py
> @@ -285,7 +285,7 @@ class RPCClient(object):
> return self.socket.recv(*args, **kwargs)
> except socket.error as err:
> if err.errno == errno.EINTR:
> - self2.recv(*arg, **kwargs)
> + return self2.recv(*args, **kwargs)
> else:
> raise err
>
> @@ -294,7 +294,7 @@ class RPCClient(object):
> return self.socket.sendall(*args, **kwargs)
> except socket.error as err:
> if err.errno == errno.EINTR:
> - self2.sendall(*arg, **kwargs)
> + return self2.sendall(*args, **kwargs)
> else:
> raise err
>
>
