[27250] in Source-Commits
Re: discuss commit: Fix segmentation fault on listing transactions
daemon@ATHENA.MIT.EDU (Alex Chernyakhovsky)
Sun Aug 25 14:40:48 2013
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.00.1308251428020.20647@dr-wily.mit.edu>
Date: Sun, 25 Aug 2013 14:40:39 -0400
Message-ID: <CAB18ysqkyOvhH=1SGkN2g-cK3A6xyAwiyiUVk=393YL5_nO4Fg@mail.gmail.com>
From: Alex Chernyakhovsky <achernya@MIT.EDU>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Jonathan Reed <jdreed@MIT.EDU>, Victor Vasiliev <vasilvv@MIT.EDU>,
"source-commits@mit.edu" <source-commits@MIT.EDU>
Content-Type: text/plain; charset=ISO-8859-1
Jon and I definitely discussed this---the workflow we envision getting
to is that a developer:
* forks the repository on github, making some changes
* the developer submits a pull request
* a different debathena developer approves the changes and pushes
them to drugstore, rebasing as needed.
Sincerely,
-Alex
On Sun, Aug 25, 2013 at 2:30 PM, Anders Kaseorg <andersk@mit.edu> wrote:
> On Sun, 25 Aug 2013, Jonathan Reed wrote:
>> I don't love the fix, but I also don't love anything else in the Discuss
>> code.
>
> So, as I mentioned on Zephyr, strdup("").
>
> Now that we have the technology, what do we think about replacing the
> post-commit review period with an equivalent pre-commit review period?
>
> Anders
