[2091] in Moira
moira.exe crashes on XP when removing machines from lists
daemon@ATHENA.MIT.EDU (Qing Dong)
Fri Nov 19 15:29:26 2004
Message-Id: <5.2.1.1.2.20041119152351.02e8ddd0@hesiod>
Date: Fri, 19 Nov 2004 15:29:21 -0500
To: moiradev@mit.edu
From: Qing Dong <dongq@MIT.EDU>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Hi, I tried to remove the machine "pismere-3" from the
list win.mit.edu-openafs-opt-in using the windows moira.exe
client and the program crashed repeated due to some pointer mis-handling.
Here is the proposed change to fix it. Thanks.
Qing
Index: lists.c
===================================================================
RCS file:
\\afs\all\athena.mit.edu\astaff\project\moiradev\repository/moira/clients/moira/lists.c,v
retrieving revision 1.53
diff -c -r1.53 lists.c
*** lists.c 2003/04/06 16:57:42 1.53
--- lists.c 2004/11/19 20:21:53
***************
*** 867,873 ****
{
char *canon;
canon = canonicalize_hostname(args[LM_MEMBER]);
! free(args[LM_MEMBER]);
args[LM_MEMBER] = canon;
if (do_mr_query("delete_member_from_list", CountArgs(args),
args, NULL, NULL) == MR_SUCCESS)
--- 867,873 ----
{
char *canon;
canon = canonicalize_hostname(args[LM_MEMBER]);
! // free(args[LM_MEMBER]);
args[LM_MEMBER] = canon;
if (do_mr_query("delete_member_from_list", CountArgs(args),
args, NULL, NULL) == MR_SUCCESS)
