[2092] in Moira

home help back first fref pref prev next nref lref last post

Re: moira.exe crashes on XP when removing machines from lists

daemon@ATHENA.MIT.EDU (Garry Zacheiss)
Fri Nov 19 17:00:46 2004

Message-Id: <200411192200.iAJM0gO6010059@brad-majors.mit.edu>
To: Qing Dong <dongq@MIT.EDU>
cc: moiradev@MIT.EDU
In-Reply-To: Your message of "Fri, 19 Nov 2004 15:29:21 EST."
             <5.2.1.1.2.20041119152351.02e8ddd0@hesiod> 
Date: Fri, 19 Nov 2004 17:00:42 -0500
From: Garry Zacheiss <zacheiss@MIT.EDU>

Three points, two cosmetic and one real:

- If a line of code is wrong, remove it, don't comment it out.

- Please use C-style comments, not C++ style comments.

- I see another place in DeleteMember() where we free the same memory;
  does that also need to be fixed?

Garry

home help back first fref pref prev next nref lref last post