[4313] in BarnOwl Developers
Re: [barnowl/barnowl] Escape @ in zephyr header fields and pick a
daemon@ATHENA.MIT.EDU (Daniel JB Clark)
Tue Nov 3 13:06:06 2026
Date: Tue, 03 Nov 2026 10:06:00 -0800
From: Daniel JB Clark <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSMVYGSCQSINLXDHYULLMNWIREVBNHHQAAAAAFX6KOKD@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/193@github.com>
----==_mimepart_6aea2288832b2_10312d05397aa
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
djbclark left a comment (barnowl/barnowl#193)
Testing status: **not done yet.** I ran this PR's own tests on master and on the branch, plus a live BarnOwl check with injected messages (before/after screenshots and logs), but I still need to review that evidence myself before calling it tested.
Findings: the new `t/BarnOwl_Style_Default.t` fails on master (112 failures, matching the description) and passes on the branch. Live: an instance `@b(x` bolds the rest of the header on master and is shown literally on the branch; a class `@color(red)red` recolours the header on master and is shown literally on the branch; the oneline style behaves the same.
Note: it conflicts textually with #196 in `Default.pm` and `OneLine.pm` (see that PR). Nothing here needs a human beyond a look at the screenshots.
--
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/193#issuecomment-6611691938
You are receiving this because you are subscribed to this thread.
Message ID: <barnowl/barnowl/pull/193/c6611691938@github.com>
----==_mimepart_6aea2288832b2_10312d05397aa
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; alig=
n-items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius=
:50%; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githu=
busercontent.com/u/131936?s=3D20&v=3D4" /><strong>djbclark</strong> l=
eft a comment <a href=3D"https://github.com/barnowl/barnowl/pull/193#issu=
ecomment-6611691938">(barnowl/barnowl#193)</a></div>
<p dir=3D"auto">Testing status: <strong>not done yet.</strong> I ran this=
PR's own tests on master and on the branch, plus a live BarnOwl check wi=
th injected messages (before/after screenshots and logs), but I still nee=
d to review that evidence myself before calling it tested.</p>
<p dir=3D"auto">Findings: the new <code class=3D"notranslate">t/BarnOwl_S=
tyle_Default.t</code> fails on master (112 failures, matching the descrip=
tion) and passes on the branch. Live: an instance <code class=3D"notransl=
ate">@b(x</code> bolds the rest of the header on master and is shown lite=
rally on the branch; a class <code class=3D"notranslate">@color(red)red</=
code> recolours the header on master and is shown literally on the branch=
; the oneline style behaves the same.</p>
<p dir=3D"auto">Note: it conflicts textually with <a class=3D"issue-link =
js-issue-link" data-error-text=3D"Failed to load title" data-id=3D"617407=
4872" data-permission-text=3D"Title is private" data-url=3D"https://githu=
b.com/barnowl/barnowl/issues/196" data-hovercard-type=3D"pull_request" da=
ta-hovercard-url=3D"/barnowl/barnowl/pull/196/hovercard" href=3D"https://=
github.com/barnowl/barnowl/pull/196">#196</a> in <code class=3D"notransla=
te">Default.pm</code> and <code class=3D"notranslate">OneLine.pm</code> (=
see that PR). Nothing here needs a human beyond a look at the screenshots=
.</p>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/193?email_source=3Dnotifications&email_token=3DABC=
ERSPMJRKOU2RZUU6YHY35XINARA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW=
2ZLOOQXTMNRRGE3DSMJZGM4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXE=
X3DNRUWG2Y#issuecomment-6611691938">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ABCERSMABU62KK7OSZJTRJ3=
5XINARAVCNFSNUABCKJSXA33TNF2G64TZHM3TINZTGA4TWSLTON2WKOZWGE3TEMRWGA3DONNB=
OYBA">unsubscribe</a>.<br />Triage notifications, keep track of coding ag=
ent tasks and review pull requests on the go with GitHub Mobile for <a hr=
ef=3D"https://github.com/notifications/mobile/ios/ABCERSO43YWY6MOQCVJ5JID=
5XINARA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSMJZ=
GM4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and=
<a href=3D"https://github.com/notifications/mobile/android/ABCERSOSNJW2R=
LKAEGUEYSL5XINARA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMN=
RRGE3DSMJZGM4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33=
JMQ">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSOET32RERHPL2DZDET=
5XINARBFCNFSM6AAAAADEC3XQYGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3P=
NVWWK3TUL5UWJTYAAAAADCQWNGRKM4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1=
" width=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0;=
display: none; visibility: hidden; overflow: hidden; opacity: 0; width: =
0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <sp=
an><barnowl/barnowl/pull/193/c6611691938</span><span>@</span><span>git=
hub</span><span>.</span><span>com></span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/193?email_source=3Dnot=
ifications\u0026email_token=3DABCERSKHLTLAYW7MEOKHVQT5XINARA5CNFSNUABFM5U=
WIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSMJZGM4KM4TFMFZW63VKON2W=
E43DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6611691938",
"url": "https://github.com/barnowl/barnowl/pull/193?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSKHLTLAYW7MEOKHVQT5XINARA5CNFSNUABFM5UWIO=
RPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSMJZGM4KM4TFMFZW63VKON2WE43=
DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6611691938",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6aea2288832b2_10312d05397aa--
