[4312] in BarnOwl Developers
Re: [barnowl/barnowl] Make bidi, tag and zero-width space characters
daemon@ATHENA.MIT.EDU (Daniel JB Clark)
Tue Nov 3 13:06:06 2026
Date: Tue, 03 Nov 2026 10:06:02 -0800
From: Daniel JB Clark <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSM7WLTWA72NWD7QJWTLMNWIVEVBNHHQAAAAAFX6ZVPJ@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/195@github.com>
----==_mimepart_6aea228a9a8c8_14a12d08726cc
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
djbclark left a comment (barnowl/barnowl#195)
Testing status: **not done yet.** I ran this PR's own tests on master and on the branch, plus a live BarnOwl check with injected messages (before/after screenshots and logs), but I still need to review that evidence myself before calling it tested.
Findings: the new `t/BarnOwl_Style_Humanize.t` fails on master (154 of 324 assertions) and passes on the branch. Live: an instance with U+202E, a sender with a zero-width space, tag characters and a word joiner are invisible on master and shown as highlighted `\x{...}` on the branch (oneline too).
Interaction with #197: that test expects DEL in the oneline style as `\x{7f}`, but with #197 merged DEL becomes `^?`, so on a combined tree `make check` fails that one assertion (1 of 1580). Whichever merges second needs its test updated.
Could use a human: real Hebrew, Arabic and Khmer text, which the description says are affected by the zero-width-space change.
--
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/195#issuecomment-6611693095
You are receiving this because you are subscribed to this thread.
Message ID: <barnowl/barnowl/pull/195/c6611693095@github.com>
----==_mimepart_6aea228a9a8c8_14a12d08726cc
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; alig=
n-items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius=
:50%; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githu=
busercontent.com/u/131936?s=3D20&v=3D4" /><strong>djbclark</strong> l=
eft a comment <a href=3D"https://github.com/barnowl/barnowl/pull/195#issu=
ecomment-6611693095">(barnowl/barnowl#195)</a></div>
<p dir=3D"auto">Testing status: <strong>not done yet.</strong> I ran this=
PR's own tests on master and on the branch, plus a live BarnOwl check wi=
th injected messages (before/after screenshots and logs), but I still nee=
d to review that evidence myself before calling it tested.</p>
<p dir=3D"auto">Findings: the new <code class=3D"notranslate">t/BarnOwl_S=
tyle_Humanize.t</code> fails on master (154 of 324 assertions) and passes=
on the branch. Live: an instance with U+202E, a sender with a zero-width=
space, tag characters and a word joiner are invisible on master and show=
n as highlighted <code class=3D"notranslate">\x{...}</code> on the branch=
(oneline too).</p>
<p dir=3D"auto">Interaction with <a class=3D"issue-link js-issue-link" da=
ta-error-text=3D"Failed to load title" data-id=3D"6174075353" data-permis=
sion-text=3D"Title is private" data-url=3D"https://github.com/barnowl/bar=
nowl/issues/197" data-hovercard-type=3D"pull_request" data-hovercard-url=3D=
"/barnowl/barnowl/pull/197/hovercard" href=3D"https://github.com/barnowl/=
barnowl/pull/197">#197</a>: that test expects DEL in the oneline style as=
<code class=3D"notranslate">\x{7f}</code>, but with <a class=3D"issue-li=
nk js-issue-link" data-error-text=3D"Failed to load title" data-id=3D"617=
4075353" data-permission-text=3D"Title is private" data-url=3D"https://gi=
thub.com/barnowl/barnowl/issues/197" data-hovercard-type=3D"pull_request"=
data-hovercard-url=3D"/barnowl/barnowl/pull/197/hovercard" href=3D"https=
://github.com/barnowl/barnowl/pull/197">#197</a> merged DEL becomes <code=
class=3D"notranslate">^?</code>, so on a combined tree <code class=3D"no=
translate">make check</code> fails that one assertion (1 of 1580). Whiche=
ver merges second needs its test updated.</p>
<p dir=3D"auto">Could use a human: real Hebrew, Arabic and Khmer text, wh=
ich the description says are affected by the zero-width-space change.</p>=
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/195?email_source=3Dnotifications&email_token=3DABC=
ERSMRNFEWTVV3MDJOM735XINAVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW=
2ZLOOQXTMNRRGE3DSMZQHE22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXE=
X3DNRUWG2Y#issuecomment-6611693095">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ABCERSILVIDU6TNULNKFKJD=
5XINAVAVCNFSNUABCKJSXA33TNF2G64TZHM3TINZTGA4TWSLTON2WKOZWGE3TENZVHE2TEONB=
OYBA">unsubscribe</a>.<br />Triage notifications, keep track of coding ag=
ent tasks and review pull requests on the go with GitHub Mobile for <a hr=
ef=3D"https://github.com/notifications/mobile/ios/ABCERSOYOQYTXFHJCUR4RZD=
5XINAVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSMZQ=
HE22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and=
<a href=3D"https://github.com/notifications/mobile/android/ABCERSJ7VEVQW=
76ACFNWVOD5XINAVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMN=
RRGE3DSMZQHE22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33=
JMQ">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSIEZNH7MJS4RGF5OJ3=
5XINAVBFCNFSM6AAAAADEC6VOISWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3P=
NVWWK3TUL5UWJTYAAAAADCQWNYT2M4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1=
" width=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0;=
display: none; visibility: hidden; overflow: hidden; opacity: 0; width: =
0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <sp=
an><barnowl/barnowl/pull/195/c6611693095</span><span>@</span><span>git=
hub</span><span>.</span><span>com></span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/195?email_source=3Dnot=
ifications\u0026email_token=3DABCERSL3XQRY3I3ND35J6G35XINAVA5CNFSNUABFM5U=
WIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSMZQHE22M4TFMFZW63VKON2W=
E43DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6611693095",
"url": "https://github.com/barnowl/barnowl/pull/195?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSL3XQRY3I3ND35J6G35XINAVA5CNFSNUABFM5UWIO=
RPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSMZQHE22M4TFMFZW63VKON2WE43=
DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6611693095",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6aea228a9a8c8_14a12d08726cc--
