[4318] in BarnOwl Developers
Re: [barnowl/barnowl] Fix boldify when the text contains all four
daemon@ATHENA.MIT.EDU (Daniel JB Clark)
Tue Nov 3 13:06:21 2026
Date: Tue, 03 Nov 2026 10:06:10 -0800
From: Daniel JB Clark <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSNHV2PHPIF3DPAFGGTLMNWJFEVBNHHQAAAAAFYAD4OB@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/199@github.com>
----==_mimepart_6aea229275c0d_10312d0146780
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
djbclark left a comment (barnowl/barnowl#199)
Testing status: **not done yet.** I ran this PR's own tests on master and on the branch, plus a live BarnOwl check with injected messages (before/after screenshots and logs), but I still need to review that evidence myself before calling it tested.
Findings: the new `t/style-boldify.t` fails on master (128 of 368 assertions) and passes on the branch. Live: an incoming personal zephyr containing `) > } ]` and `@i(ital)` leaves a stray `)` on master and renders correctly on the branch. Nothing specific for a human to check.
--
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/199#issuecomment-6611695943
You are receiving this because you are subscribed to this thread.
Message ID: <barnowl/barnowl/pull/199/c6611695943@github.com>
----==_mimepart_6aea229275c0d_10312d0146780
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; alig=
n-items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius=
:50%; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githu=
busercontent.com/u/131936?s=3D20&v=3D4" /><strong>djbclark</strong> l=
eft a comment <a href=3D"https://github.com/barnowl/barnowl/pull/199#issu=
ecomment-6611695943">(barnowl/barnowl#199)</a></div>
<p dir=3D"auto">Testing status: <strong>not done yet.</strong> I ran this=
PR's own tests on master and on the branch, plus a live BarnOwl check wi=
th injected messages (before/after screenshots and logs), but I still nee=
d to review that evidence myself before calling it tested.</p>
<p dir=3D"auto">Findings: the new <code class=3D"notranslate">t/style-bol=
dify.t</code> fails on master (128 of 368 assertions) and passes on the b=
ranch. Live: an incoming personal zephyr containing <code class=3D"notran=
slate">) > } ]</code> and <code class=3D"notranslate">@i(ital)</code> =
leaves a stray <code class=3D"notranslate">)</code> on master and renders=
correctly on the branch. Nothing specific for a human to check.</p>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/199?email_source=3Dnotifications&email_token=3DABC=
ERSLKDIWD76W6OGUJNAT5XINBFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW=
2ZLOOQXTMNRRGE3DSNJZGQZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXE=
X3DNRUWG2Y#issuecomment-6611695943">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ABCERSJCMIJN2VU37OVFXOT=
5XINBFAVCNFSNUABCKJSXA33TNF2G64TZHM3TINZTGA4TWSLTON2WKOZWGE3TIMJUGI4TCM5B=
OYBA">unsubscribe</a>.<br />Triage notifications, keep track of coding ag=
ent tasks and review pull requests on the go with GitHub Mobile for <a hr=
ef=3D"https://github.com/notifications/mobile/ios/ABCERSPZ74DH46QTPTXIO73=
5XINBFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSNJZ=
GQZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and=
<a href=3D"https://github.com/notifications/mobile/android/ABCERSLEPWOIX=
OZC5EGXI6D5XINBFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMN=
RRGE3DSNJZGQZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33=
JMQ">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSKTPEXYX3Y6YZ6ENVD=
5XINBFBFCNFSM6AAAAADEDGWRJ6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3P=
NVWWK3TUL5UWJTYAAAAADCQWPFD2M4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1=
" width=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0;=
display: none; visibility: hidden; overflow: hidden; opacity: 0; width: =
0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <sp=
an><barnowl/barnowl/pull/199/c6611695943</span><span>@</span><span>git=
hub</span><span>.</span><span>com></span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/199?email_source=3Dnot=
ifications\u0026email_token=3DABCERSKY4OQS4WZ2Q22QWGD5XINBFA5CNFSNUABFM5U=
WIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSNJZGQZ2M4TFMFZW63VKON2W=
E43DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6611695943",
"url": "https://github.com/barnowl/barnowl/pull/199?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSKY4OQS4WZ2Q22QWGD5XINBFA5CNFSNUABFM5UWIO=
RPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSNJZGQZ2M4TFMFZW63VKON2WE43=
DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6611695943",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6aea229275c0d_10312d0146780--
