[4297] in BarnOwl Developers
[barnowl/barnowl] Show DEL as ^? in humanize (PR #197)
daemon@ATHENA.MIT.EDU (Daniel JB Clark)
Mon Nov 2 20:08:11 2026
Date: Mon, 02 Nov 2026 17:06:36 -0800
From: Daniel JB Clark <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSO2APVJWMUE5LTOLJLLMJ6ZZEVBNHHQAAAAAFYAB2OZ@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
----==_mimepart_6ae9339c3cdee_dc12d0113164
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Body:
`_humanize_char` compares the character with 255 where it means DEL (127). DEL was shown as `\x{7f}` while the comparison for 255 made no difference to printable U+00FF (it never reaches `_humanize_char`, because it is printable). Compare with 127. DEL matches both of `humanize`'s classes (`[[:cntrl:]]` and `[^[:print:]\n]`), so it takes this branch in both modes.
One-line change, based on master; independent of #195 (fix-humanize-invisible), which edits `humanize` nearby.
Tested: new t/style-humanize-del.t (DEL in both modes, with colorztext, in text and with ESC; U+00FF, C1 and C0 unchanged); the DEL assertions fail on master, pass with the change; `make check` green on Linux.
You can view, comment on, or merge this pull request online at:
https://github.com/barnowl/barnowl/pull/197
-- Commit Summary --
* Show DEL as ^? in humanize
-- File Changes --
M perl/lib/BarnOwl/Style/Default.pm (2)
A t/style-humanize-del.t (71)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/197.patch
https://github.com/barnowl/barnowl/pull/197.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/197
You are receiving this because you are subscribed to this thread.
Message ID: <barnowl/barnowl/pull/197@github.com>
----==_mimepart_6ae9339c3cdee_dc12d0113164
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<p dir=3D"auto">Body:<br>
<code class=3D"notranslate">_humanize_char</code> compares the character =
with 255 where it means DEL (127). DEL was shown as <code class=3D"notran=
slate">\x{7f}</code> while the comparison for 255 made no difference to p=
rintable U+00FF (it never reaches <code class=3D"notranslate">_humanize_c=
har</code>, because it is printable). Compare with 127. DEL matches both =
of <code class=3D"notranslate">humanize</code>'s classes (<code class=3D"=
notranslate">[[:cntrl:]]</code> and <code class=3D"notranslate">[^[:print=
:]\n]</code>), so it takes this branch in both modes.</p>
<p dir=3D"auto">One-line change, based on master; independent of <a class=
=3D"issue-link js-issue-link" data-error-text=3D"Failed to load title" da=
ta-id=3D"6172759529" data-permission-text=3D"Title is private" data-url=3D=
"https://github.com/barnowl/barnowl/issues/195" data-hovercard-type=3D"pu=
ll_request" data-hovercard-url=3D"/barnowl/barnowl/pull/195/hovercard" hr=
ef=3D"https://github.com/barnowl/barnowl/pull/195">#195</a> (fix-humanize=
-invisible), which edits <code class=3D"notranslate">humanize</code> near=
by.</p>
<p dir=3D"auto">Tested: new t/style-humanize-del.t (DEL in both modes, wi=
th colorztext, in text and with ESC; U+00FF, C1 and C0 unchanged); the DE=
L assertions fail on master, pass with the change; <code class=3D"notrans=
late">make check</code> green on Linux.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href=3D'https://github.com/barnowl/barnowl/pull/197'>ht=
tps://github.com/barnowl/barnowl/pull/197</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href=3D"https://github.com/barnowl/barnowl/pull/197/commits/8c31=
e660590a158ba6c328bed7add5f7680e2bcc" class=3D"commit-link">8c31e66</a> =
Show DEL as ^? in humanize</li>
</ul>
<h4 style=3D"display: inline-block">File Changes </h4> <p style=3D"displa=
y: inline-block">(<a href=3D"https://github.com/barnowl/barnowl/pull/197/=
files">2 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/197/files#diff-53a=
aefd5b60dc926b6ea112e29812e602750c8528602516818c98c23ac979853">perl/lib/B=
arnOwl/Style/Default.pm</a>
(2)
</li>
<li>
<strong>A</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/197/files#diff-963=
4e7039a48542e67aab4027be816f689fa3a7bf1b420cea4f76e113ed3b838">t/style-hu=
manize-del.t</a>
(71)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href=3D'https://github.com/barnowl/barnowl/pull/197.patch'>https=
://github.com/barnowl/barnowl/pull/197.patch</a></li>
<li><a href=3D'https://github.com/barnowl/barnowl/pull/197.diff'>https:=
//github.com/barnowl/barnowl/pull/197.diff</a></li>
</ul>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/197?email_source=3Dnotifications&email_token=3DABC=
ERSL7E2CVNOBZT6QQQAT5XEVRZA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2W=
K43UF42TCMZQGAZTAMRTGCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVRTG633UMVZF6=
Y3MNFRWW">view it on GitHub</a>, or <a href=3D"https://github.com/notific=
ations/unsubscribe-auth/ABCERSI4LPPFEMNTIWMXNI35XEVRZAVCNFSNUABCKJSXA33TN=
F2G64TZHM3TINZTGA4TWSLTON2WKOZWGE3TIMBXGUZTKM5BOYBA">unsubscribe</a>.<br =
/>Triage notifications, keep track of coding agent tasks and review pull =
requests on the go with GitHub Mobile for <a href=3D"https://github.com/n=
otifications/mobile/ios/ABCERSKWYO67BKPV3PLXQVL5XEVRZA5CNFSNUABEM5UWIORPF=
5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TCMZQGAZTAMRTGCTHEZLBONXW5KTTOVRHGY3SNF=
RGKZFFMV3GK3TUVJTG633UMVZF62LPOM">iOS</a> and <a href=3D"https://github.c=
om/notifications/mobile/android/ABCERSKT3HZ55JJ24MLUH7D5XEVRZA5CNFSNUABEM=
5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TCMZQGAZTAMRTGCTHEZLBONXW5KTTOV=
RHGY3SNFRGKZFFMV3GK3TUVZTG633UMVZF6YLOMRZG62LE">Android</a>. Download it =
today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSMP53RUAQFR5D74MQT=
5XEVRZBFCNFSM6AAAAADEDGLNRGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3J=
MTHQAAAAAFYAB2OZUZZGKYLTN5XKU43VMJZWG4TJMJSWI.gif" height=3D"1" width=3D"=
1" alt=3D"" /><span style=3D"color: transparent; font-size: 0; display: n=
one; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: =
0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><barn=
owl/barnowl/pull/197</span><span>@</span><span>github</span><span>.</span=
><span>com></span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/197?email_source=3Dnot=
ifications\u0026email_token=3DABCERSLI375PSJMD62IB65T5XEVRZA5CNFSNUABEM5U=
WIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TCMZQGAZTAMRTGCTHEZLBONXW5KTTOVRH=
GY3SNFRGKZFFMV3GK3TUVNTW2YLJNRPWG3DJMNVQ",
"url": "https://github.com/barnowl/barnowl/pull/197?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSLI375PSJMD62IB65T5XEVRZA5CNFSNUABEM5UWIO=
RPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TCMZQGAZTAMRTGCTHEZLBONXW5KTTOVRHGY3=
SNFRGKZFFMV3GK3TUVNTW2YLJNRPWG3DJMNVQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6ae9339c3cdee_dc12d0113164--
