[4296] in BarnOwl Developers
[barnowl/barnowl] Make the basic style inherit from the default style
daemon@ATHENA.MIT.EDU (Daniel JB Clark)
Mon Nov 2 20:06:42 2026
Date: Mon, 02 Nov 2026 17:06:40 -0800
From: Daniel JB Clark <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSKCSZ4NTGBZRARFHM3LMJ62BEVBNHHQAAAAAFYAB243@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
----==_mimepart_6ae933a0134f0_f112d01031bc
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
BarnOwl::Style::Basic had `use lib qw(BarnOwl::Style::Default)` where `use base` was meant, so it inherited nothing and had no format_message. style.c calls format_message on the style object, so `:view -s basic` (or default_style basic) errored "Can't locate object method format_message" and showed "<unformatted message>" for every message. Use `use base`, as OneLine does, and fix "Compatability" in the description.
Tested: new t/style-basic.t checks basic formats messages like default; fails on master, passes in CI on this branch: https://github.com/djbclark/barnowl/actions/runs/41555741170.
You can view, comment on, or merge this pull request online at:
https://github.com/barnowl/barnowl/pull/198
-- Commit Summary --
* Make the basic style inherit from the default style
-- File Changes --
M perl/lib/BarnOwl/Style/Basic.pm (5)
A t/style-basic.t (52)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/198.patch
https://github.com/barnowl/barnowl/pull/198.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/198
You are receiving this because you are subscribed to this thread.
Message ID: <barnowl/barnowl/pull/198@github.com>
----==_mimepart_6ae933a0134f0_f112d01031bc
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<p dir=3D"auto">BarnOwl::Style::Basic had <code class=3D"notranslate">use=
lib qw(BarnOwl::Style::Default)</code> where <code class=3D"notranslate"=
>use base</code> was meant, so it inherited nothing and had no format_mes=
sage. style.c calls format_message on the style object, so <code class=3D=
"notranslate">:view -s basic</code> (or default_style basic) errored "Can=
't locate object method format_message" and showed "" for every message. =
Use <code class=3D"notranslate">use base</code>, as OneLine does, and fix=
"Compatability" in the description.<br>
Tested: new t/style-basic.t checks basic formats messages like default; f=
ails on master, passes in CI on this branch: <a href=3D"https://github.co=
m/djbclark/barnowl/actions/runs/41555741170">https://github.com/djbclark/=
barnowl/actions/runs/41555741170</a>.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href=3D'https://github.com/barnowl/barnowl/pull/198'>ht=
tps://github.com/barnowl/barnowl/pull/198</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href=3D"https://github.com/barnowl/barnowl/pull/198/commits/219f=
1f7cb9ace9d3afe9f87d2a4cb4a2f454ffff" class=3D"commit-link">219f1f7</a> =
Make the basic style inherit from the default style</li>
</ul>
<h4 style=3D"display: inline-block">File Changes </h4> <p style=3D"displa=
y: inline-block">(<a href=3D"https://github.com/barnowl/barnowl/pull/198/=
files">2 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/198/files#diff-de3=
55c7b8456be0bb27a2e8919b4ddda1bbd157c27141b9595cdd5659da0d1cd">perl/lib/B=
arnOwl/Style/Basic.pm</a>
(5)
</li>
<li>
<strong>A</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/198/files#diff-4f8=
60eaa4d1a0a9889964d2d1a3f6ba26ff61a18f0425a7577e78cae4e03e330">t/style-ba=
sic.t</a>
(52)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href=3D'https://github.com/barnowl/barnowl/pull/198.patch'>https=
://github.com/barnowl/barnowl/pull/198.patch</a></li>
<li><a href=3D'https://github.com/barnowl/barnowl/pull/198.diff'>https:=
//github.com/barnowl/barnowl/pull/198.diff</a></li>
</ul>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/198?email_source=3Dnotifications&email_token=3DABC=
ERSKSBMXYC6DMHG7BLFL5XEVSBA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2W=
K43UF42TCMZQGAZTANRQHCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVRTG633UMVZF6=
Y3MNFRWW">view it on GitHub</a>, or <a href=3D"https://github.com/notific=
ations/unsubscribe-auth/ABCERSLB37ZJ5QDOZ2DYRE35XEVSBAVCNFSNUABCKJSXA33TN=
F2G64TZHM3TINZTGA4TWSLTON2WKOZWGE3TIMBXGU4DAM5BOYBA">unsubscribe</a>.<br =
/>Triage notifications, keep track of coding agent tasks and review pull =
requests on the go with GitHub Mobile for <a href=3D"https://github.com/n=
otifications/mobile/ios/ABCERSIKTLRNL4D3EVGJ2PL5XEVSBA5CNFSNUABEM5UWIORPF=
5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TCMZQGAZTANRQHCTHEZLBONXW5KTTOVRHGY3SNF=
RGKZFFMV3GK3TUVJTG633UMVZF62LPOM">iOS</a> and <a href=3D"https://github.c=
om/notifications/mobile/android/ABCERSKAGHMRLNN666OMWYT5XEVSBA5CNFSNUABEM=
5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TCMZQGAZTANRQHCTHEZLBONXW5KTTOV=
RHGY3SNFRGKZFFMV3GK3TUVZTG633UMVZF6YLOMRZG62LE">Android</a>. Download it =
today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSO3NZDEKZLUDDBCCCL=
5XEVSBBFCNFSM6AAAAADEDGLQ7OWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3J=
MTHQAAAAAFYAB243UZZGKYLTN5XKU43VMJZWG4TJMJSWI.gif" height=3D"1" width=3D"=
1" alt=3D"" /><span style=3D"color: transparent; font-size: 0; display: n=
one; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: =
0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><barn=
owl/barnowl/pull/198</span><span>@</span><span>github</span><span>.</span=
><span>com></span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/198?email_source=3Dnot=
ifications\u0026email_token=3DABCERSL5BHOJVJBLHUCXS5D5XEVSBA5CNFSNUABEM5U=
WIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TCMZQGAZTANRQHCTHEZLBONXW5KTTOVRH=
GY3SNFRGKZFFMV3GK3TUVNTW2YLJNRPWG3DJMNVQ",
"url": "https://github.com/barnowl/barnowl/pull/198?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSL5BHOJVJBLHUCXS5D5XEVSBA5CNFSNUABEM5UWIO=
RPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TCMZQGAZTANRQHCTHEZLBONXW5KTTOVRHGY3=
SNFRGKZFFMV3GK3TUVNTW2YLJNRPWG3DJMNVQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6ae933a0134f0_f112d01031bc--
