[2974] in BarnOwl Developers
Re: [PATCH] Add | to OWL_REGEX_QUOTECHARS
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Mon Mar 14 15:14:31 2011
Date: Mon, 14 Mar 2011 15:14:28 -0400 (EDT)
From: Anders Kaseorg <andersk@MIT.EDU>
To: Karl Ramm <kcr@1ts.org>
cc: barnowl-dev@mit.edu
In-Reply-To: <uusbp1dcz7k.fsf@1ts.org>
On Mon, 14 Mar 2011, Karl Ramm wrote:
> I can guess, but why exactly is this a good idea?
Because, uh, | is a regex metacharacter that needs to be escaped when used=
=20
in an owl_regex, and OWL_REGEX_QUOTECHARS is supposed to be the set of=20
regex metacharacters that need to be escaped when used in an owl_regex,=20
and it=E2=80=99s a probably good idea to include a regex metacharacter that=
needs=20
to be escaped when used in an owl_regex in the set of regex metacharacters=
=20
that need to be escaped when used in an owl_regex.
> (lacking a justification, the commit message might as well be "foo" as=20
> it just restates the diff.)
I recognize that you=E2=80=99re trying to argue that the commit message sho=
uld=20
contain more content, but this is not such an argument. Commit messages=20
aren=E2=80=99t like inline code comments: a commit message that restates th=
e diff=20
_is_ useful for git log, gitk, gitweb, and so on, while =E2=80=9Cfoo=E2=80=
=9D would not=20
be.
However, I=E2=80=99ve repushed to git://andersk.mit.edu/barnowl.git regex w=
ith a=20
longer commit message.
Anders
