[2973] in BarnOwl Developers
Re: [PATCH] Add | to OWL_REGEX_QUOTECHARS
daemon@ATHENA.MIT.EDU (Jeffrey Hutzelman)
Mon Mar 14 15:13:33 2011
From: Jeffrey Hutzelman <jhutz@cmu.edu>
To: Karl Ramm <kcr@1ts.org>
Cc: jhutz@cmu.edu, Anders Kaseorg <andersk@mit.edu>, barnowl-dev@mit.edu
In-Reply-To: <uusbp1dcz7k.fsf@1ts.org>
Date: Mon, 14 Mar 2011 15:13:30 -0400
On Mon, 2011-03-14 at 14:51 -0400, Karl Ramm wrote:
> I can guess, but why exactly is this a good idea? (lacking a
> justification, the commit message might as well be "foo" as it just
> restates the diff.)
>
> kcr
>
> Anders Kaseorg <andersk@MIT.EDU> writes:
>
> > Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> > ---
> > owl.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/owl.h b/owl.h
> > index 96640c6..e747740 100644
> > --- a/owl.h
> > +++ b/owl.h
> > @@ -202,7 +202,7 @@ typedef void HV;
> > #define OWL_ZEPHYR_NOSTRIP_DAEMON5 "daemon/"
> > #define OWL_ZEPHYR_NOSTRIP_DAEMON4 "daemon."
> >
> > -#define OWL_REGEX_QUOTECHARS "!+*.?[]^\\${}()"
> > +#define OWL_REGEX_QUOTECHARS "!+*.?[]^\\${}()|"
> > #define OWL_REGEX_QUOTEWITH "\\"
> >
> > #if defined(HAVE_DES_STRING_TO_KEY) && defined(HAVE_DES_KEY_SCHED) && defined(HAVE_DES_ECB_ENCRYPT)
>
Wait. What is OWL_REGEX_QUOTECHARS for?
It seems to me that likely answers will all point to the correct value
being a function of the particular RE syntax in use. If the RE syntax
in use is always that of Perl (or Python, for that matter), then the
correct set of things to quote is "anything that is not a letter or
digit".
-- Jeff
