[2954] in BarnOwl Developers
[barnowl/barnowl] 488913: owl_zephyr_initialize only needs one zephyr librar...
daemon@ATHENA.MIT.EDU (noreply@github.com)
Sun Mar 6 14:15:10 2011
Date: Sun, 6 Mar 2011 11:15:07 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 488913a20506f171479d3bd93ef02ae1d9c4e00d
https://github.com/barnowl/barnowl/commit/488913a20506f171479d3bd93ef02ae1d9c4e00d
Author: Karl Ramm <kcr@1ts.org>
Date: 2011-03-06 (Sun, 06 Mar 2011)
Changed paths:
M zephyr.c
Log Message:
-----------
owl_zephyr_initialize only needs one zephyr library return value
It doesn't need two separate return-value variabels, and the one
should be a Code_t.
Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
Commit: c73a22deca75633bf37ce8ff65436c3b1e2b5ae3
https://github.com/barnowl/barnowl/commit/c73a22deca75633bf37ce8ff65436c3b1e2b5ae3
Author: Karl Ramm <kcr@1ts.org>
Date: 2011-03-06 (Sun, 06 Mar 2011)
Changed paths:
M zephyr.c
Log Message:
-----------
when something goes wrong, give more information about what happened
These various utility functions, instead of just saying "there was an
error", should report to the user what the library thinks went wrong
so they user has some small chance of debugging the problem.
Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
Commit: 00842c378ec40696438bc0d2f39bdcc757de5268
https://github.com/barnowl/barnowl/commit/00842c378ec40696438bc0d2f39bdcc757de5268
Author: Karl Ramm <kcr@1ts.org>
Date: 2011-03-06 (Sun, 06 Mar 2011)
Changed paths:
M zephyr.c
Log Message:
-----------
make the unsuball functions's error handling fit in with the rest of the program
"what is this, I don't even"
runing com_err in the middle of a curses program is just plain wrong.
Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
Commit: c51867666e5acf4c88fc5dff8ce130627d83f2d0
https://github.com/barnowl/barnowl/commit/c51867666e5acf4c88fc5dff8ce130627d83f2d0
Author: Karl Ramm <kcr@1ts.org>
Date: 2011-03-06 (Sun, 06 Mar 2011)
Changed paths:
M zephyr.c
Log Message:
-----------
refactor owl_zephyr_get_message
Refactor and make the control flow simpler. Really this code
should get moved to perl.
Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
Commit: 7d969f31f2bcc9221bbf3a80d3eea1607670719f
https://github.com/barnowl/barnowl/commit/7d969f31f2bcc9221bbf3a80d3eea1607670719f
Author: Karl Ramm <kcr@1ts.org>
Date: 2011-03-06 (Sun, 06 Mar 2011)
Changed paths:
M zephyr.c
Log Message:
-----------
refactor owl_zephyr_zlog_in and report errors in owl_zephyr_zlog_{in,out}
Use the function ZParseExposureLevel thoughtfully provided by the library,
and see what happens when we actually report errors that occur here.
Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
Compare: https://github.com/barnowl/barnowl/compare/e3a75ed...7d969f3
