[2953] in BarnOwl Developers
[barnowl/barnowl] 010a95: Make owl_variable's get_tostring_fn return a newly...
daemon@ATHENA.MIT.EDU (noreply@github.com)
Sat Mar 5 15:25:55 2011
Date: Sat, 5 Mar 2011 12:25:53 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 010a9511420887329269aa51e7598533e826c57f
https://github.com/barnowl/barnowl/commit/010a9511420887329269aa51e7598533e826c57f
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-05 (Sat, 05 Mar 2011)
Changed paths:
M commands.c
M functions.c
M owl.h
M tester.c
M variable.c
Log Message:
-----------
Make owl_variable's get_tostring_fn return a newly allocated string
The mess with buffer lengths and whatnot is obnoxious. Note that this
does change semantics slightly: instead of (optionally) filling a buffer
and giving a return code for good vs no-variable/invalid, we now return
NULL for missing variables and always return a string if the variable
exists. This also appears to be more accurate from the perspective of
the calls anyway.
Commit: e3a75ed002d36684faf777a949ef38ff9552b73f
https://github.com/barnowl/barnowl/commit/e3a75ed002d36684faf777a949ef38ff9552b73f
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-05 (Sat, 05 Mar 2011)
Changed paths:
M functions.c
M logging.c
M zephyr.c
Log Message:
-----------
Replace the remaining snprintfs with g_strdup_printf
Hard-coded buffer sizes are silly.
Compare: https://github.com/barnowl/barnowl/compare/9620c8d...e3a75ed
