[2866] in BarnOwl Developers
[barnowl/barnowl] 569f0b: Fix up feature macros somewhat
daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Jan 20 20:01:37 2011
Date: Thu, 20 Jan 2011 17:01:34 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 569f0bd492d8a1015b79c2ffb31a47b52ea5ef8d
https://github.com/barnowl/barnowl/commit/569f0bd492d8a1015b79c2ffb31a47b52ea5ef8d
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M configure.ac
Log Message:
-----------
Fix up feature macros somewhat
Set _XOPEN_SOURCE to 500 to target a sufficiently new standard. Also
define _BSD_SOURCE because zephyr needs a BSD extension (caddr_t).
Apparently both of these bugs were masked on Debathena because Ubuntu's
perl defines _GNU_SOURCE which turns everything on.
This also removes the need for __EXTENSIONS__ to get struct timeval on
Solaris. But we can't quite get rid of it yet because we use strcasecmp
and MAXHOSTNAMELEN.
Reported-By: Alex Vandiver <alexmv@mit.edu>
Commit: c7fe23e76c2953cbe18fdb7c99a32e1fc431c0f1
https://github.com/barnowl/barnowl/commit/c7fe23e76c2953cbe18fdb7c99a32e1fc431c0f1
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M commands.c
M functions.c
Log Message:
-----------
If a smartfilter fails to parse, handle the error
Otherwise we segfault. Of course, we should always succeed in creating a
filter, but we sometimes don't because of quoting bugs.
Commit: b31252dfeaff188c43a4a4b2b6bc51e9e7026492
https://github.com/barnowl/barnowl/commit/b31252dfeaff188c43a4a4b2b6bc51e9e7026492
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M tester.c
Log Message:
-----------
Add a few unit tests for classinstfilt
They currently fail because our quoting is buggy.
Commit: 443dcfa9a8423813959361f857af7f64ce7433d1
https://github.com/barnowl/barnowl/commit/443dcfa9a8423813959361f857af7f64ce7433d1
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M tester.c
Log Message:
-----------
Add a test for zuserfilt
Commit: f47696fa9c3bcde475c6715272a637d52e2999f4
https://github.com/barnowl/barnowl/commit/f47696fa9c3bcde475c6715272a637d52e2999f4
Author: Nelson Elhage <nelhage@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M tester.c
M util.c
Log Message:
-----------
Add owl_string_appendf_quoted for easy construction of command lines.
Commit: c426bc2d7759015c30b32962af87de2bc0941785
https://github.com/barnowl/barnowl/commit/c426bc2d7759015c30b32962af87de2bc0941785
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Rewrite owl_function_classinstfilt with proper quoting
The current ad-hoc code fails to handle tabs, which allows an attacker
to force a failed parse or run an arbitrary perl function.
[nelhage@nelhage.com: Use owl_string_appendf_quoted]
Commit: a5f477c87d80076e805e45ccc8acaf6b9bf2c527
https://github.com/barnowl/barnowl/commit/a5f477c87d80076e805e45ccc8acaf6b9bf2c527
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Reimplement owl_function_zuserfilt with proper quoting
[nelhage@nelhage.com: Use owl_string_appendf_quoted]
Commit: 9d4c39859708ecc969bce82fd4ccca5b8aeb8a75
https://github.com/barnowl/barnowl/commit/9d4c39859708ecc969bce82fd4ccca5b8aeb8a75
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Reimplement owl_function_zpunt using proper quoting
[nelhage@nelhage.com: Use owl_string_build_quoted]
Commit: 42115bf995447b73bf50cad34348560415dee500
https://github.com/barnowl/barnowl/commit/42115bf995447b73bf50cad34348560415dee500
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Reimplement owl_function_typefilt with proper quoting
Probably not actually a big deal, but may as well.
[nelhage@nelhage.com: Use owl_string_build_quoted]
