[2865] in BarnOwl Developers
[barnowl/barnowl] cb1759: Add owl_quote_arg and owl_string_append_quoted_arg
daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Jan 20 20:01:37 2011
Date: Thu, 20 Jan 2011 17:01:34 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/release-1.7
Home: https://github.com/barnowl/barnowl
Commit: cb1759eaf4b5681c5f598c6a6ab16f09b7c685bd
https://github.com/barnowl/barnowl/commit/cb1759eaf4b5681c5f598c6a6ab16f09b7c685bd
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M tester.c
M util.c
Log Message:
-----------
Add owl_quote_arg and owl_string_append_quoted_arg
Also add unit tests. We don't appear to have an equivalent of
BarnOwl::quote in C that actually works.
Commit: b4f7576e68bb0805bf32adbef72bc0bb36e9a14d
https://github.com/barnowl/barnowl/commit/b4f7576e68bb0805bf32adbef72bc0bb36e9a14d
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M filterelement.c
M functions.c
M global.c
M text.c
Log Message:
-----------
Kill owl_getquoting and fix quoting bugs
That function is nonsense. Fix a number of quoting bugs relating to its
use (and lack thereof).
Also quote regex characters in CC narrows.
Commit: f85278b8943b3c38ffc7ed08dfb9869f6cb7f1b9
https://github.com/barnowl/barnowl/commit/f85278b8943b3c38ffc7ed08dfb9869f6cb7f1b9
Author: Nelson Elhage <nelhage@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Don't use error_message if we are building without Zephyr.
That code path will never actually be executed if we don't have Zephyr, so let's
just '#ifdef' it out and remove the com_err dependency.
Commit: 2e5b2f9a5f7979d0372315237698ba8b236ab595
https://github.com/barnowl/barnowl/commit/2e5b2f9a5f7979d0372315237698ba8b236ab595
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M configure.ac
Log Message:
-----------
Fix up feature macros somewhat
Set _XOPEN_SOURCE to 500 to target a sufficiently new standard. Also
define _BSD_SOURCE because zephyr needs a BSD extension (caddr_t).
Apparently both of these bugs were masked on Debathena because Ubuntu's
perl defines _GNU_SOURCE which turns everything on.
This also removes the need for __EXTENSIONS__ to get struct timeval on
Solaris. But we can't quite get rid of it yet because we use strcasecmp
and MAXHOSTNAMELEN.
Reported-By: Alex Vandiver <alexmv@mit.edu>
Commit: 7013eb9642ccd31dfd15791df755d2f2152e0023
https://github.com/barnowl/barnowl/commit/7013eb9642ccd31dfd15791df755d2f2152e0023
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M commands.c
M functions.c
Log Message:
-----------
If a smartfilter fails to parse, handle the error
Otherwise we segfault. Of course, we should always succeed in creating a
filter, but we sometimes don't because of quoting bugs.
Commit: 4976e93eec8e697d7bf01c3d50f7579616cb16dc
https://github.com/barnowl/barnowl/commit/4976e93eec8e697d7bf01c3d50f7579616cb16dc
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M tester.c
Log Message:
-----------
Add a few unit tests for classinstfilt
They currently fail because our quoting is buggy.
Commit: 3812784c75b306869e9dbc993226bcaa65a67f40
https://github.com/barnowl/barnowl/commit/3812784c75b306869e9dbc993226bcaa65a67f40
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M tester.c
Log Message:
-----------
Add a test for zuserfilt
Commit: 5ded5e86abd99afbab51c937074da03076258f32
https://github.com/barnowl/barnowl/commit/5ded5e86abd99afbab51c937074da03076258f32
Author: Nelson Elhage <nelhage@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M tester.c
M util.c
Log Message:
-----------
Add owl_string_appendf_quoted for easy construction of command lines.
Commit: 47efcf500c7f47e4eaa3b3f8aad3d6e9d7ee2c43
https://github.com/barnowl/barnowl/commit/47efcf500c7f47e4eaa3b3f8aad3d6e9d7ee2c43
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Rewrite owl_function_classinstfilt with proper quoting
The current ad-hoc code fails to handle tabs, which allows an attacker
to force a failed parse or run an arbitrary perl function.
[nelhage@nelhage.com: Use owl_string_appendf_quoted]
Commit: 74df3bc30f45b6ee0574c70578d90ac4e678a832
https://github.com/barnowl/barnowl/commit/74df3bc30f45b6ee0574c70578d90ac4e678a832
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Reimplement owl_function_zuserfilt with proper quoting
[nelhage@nelhage.com: Use owl_string_appendf_quoted]
Commit: 07235af3c0f775036e8015c1aad035883c625eca
https://github.com/barnowl/barnowl/commit/07235af3c0f775036e8015c1aad035883c625eca
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Reimplement owl_function_zpunt using proper quoting
[nelhage@nelhage.com: Use owl_string_build_quoted]
Commit: 89caa9775c738233ec9723eff7b71e48c060447b
https://github.com/barnowl/barnowl/commit/89caa9775c738233ec9723eff7b71e48c060447b
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-05 (Wed, 05 Jan 2011)
Changed paths:
M functions.c
Log Message:
-----------
Reimplement owl_function_typefilt with proper quoting
Probably not actually a big deal, but may as well.
[nelhage@nelhage.com: Use owl_string_build_quoted]
Commit: b35144c9aace6030f5c6c70c4a57a62ac3f3598f
https://github.com/barnowl/barnowl/commit/b35144c9aace6030f5c6c70c4a57a62ac3f3598f
Author: David Benjamin <davidben@mit.edu>
Date: 2011-01-20 (Thu, 20 Jan 2011)
Changed paths:
M ChangeLog
M configure.ac
Log Message:
-----------
BarnOwl 1.7
