[2627] in BarnOwl Developers
Re: [PATCH] Don't ignore the error code when doing a zwrite
daemon@ATHENA.MIT.EDU (=?UTF-8?B?IkFsZWphbmRybyBSLiBTZWRl)
Tue Sep 14 10:20:30 2010
Date: Tue, 14 Sep 2010 10:20:11 -0400
From: =?UTF-8?B?IkFsZWphbmRybyBSLiBTZWRlw7FvIg==?= <asedeno@MIT.EDU>
To: Nelson Elhage <nelhage@mit.edu>
CC: Jeffrey Hutzelman <jhutz@cmu.edu>, David Benjamin <davidben@mit.edu>,
barnowl-dev@mit.edu
In-Reply-To: <87bp80quzq.fsf@mit.edu>
On 9/14/2010 10:07 AM, Nelson Elhage wrote:
> send_zephyr just does a ZSrvSendNotice (... no, I'm not sure why we need
> to do that instead of just ZSendNotice), so I believe that if they
> aren't subscribed, you won't find out until you get a ZSRVACK_NOTSENT
> back from the server, which will get processed later by the mainloop.
It's to override waiting for an ACK.
Instead of using Z_XmitFragment(), we use send_zephyr_helper() as the
send_routine argument to ZSrvSendNotice(). It's the same except that
waitforack is hardcoded to 0.
BarnOwl deals with the ACK when it comes in later.
Additionally, this dates back to the initial commit of owl.
-Alejandro
