[2626] in BarnOwl Developers
Re: [PATCH] Don't ignore the error code when doing a zwrite
daemon@ATHENA.MIT.EDU (Nelson Elhage)
Tue Sep 14 10:07:25 2010
From: Nelson Elhage <nelhage@MIT.EDU>
To: Jeffrey Hutzelman <jhutz@cmu.edu>, David Benjamin <davidben@mit.edu>,
barnowl-dev@mit.edu
Cc: jhutz@cmu.edu
In-Reply-To: <EA29CB243E87318C98F351BF@minbar.fac.cs.cmu.edu>
Date: Tue, 14 Sep 2010 10:07:21 -0400
On Tue, 14 Sep 2010 09:45:48 -0400, Jeffrey Hutzelman <jhutz@cmu.edu> wrote:
> --On Monday, September 13, 2010 09:14:01 PM -0400 Nelson Elhage
> <nelhage@mit.edu> wrote:
>
> > Cool, definitely a good call.
> >
> > It's not hugely important, but is continuing to try further recipients
> > really the right plan if one fails? I feel like I'd expect it to bail
> > out after the first error.
>
> So if I send to five recipients and the third one isn't subscribed, the
> first two get my zgram and the other two don't? Or am I misinterpreting
> how much work send_zephyr() actually does?
send_zephyr just does a ZSrvSendNotice (... no, I'm not sure why we need
to do that instead of just ZSendNotice), so I believe that if they
aren't subscribed, you won't find out until you get a ZSRVACK_NOTSENT
back from the server, which will get processed later by the mainloop.
I guess I should probably verify that before pushing this to a release,
but that's my understanding.
- Nelson
>
>
