[2403] in linux-net channel archive
Re: Frozen linux 1.3.84
daemon@ATHENA.MIT.EDU (Darren Reed)
Mon Apr 8 10:53:53 1996
From: Darren Reed <avalon@coombs.anu.edu.au>
To: torvalds@cs.helsinki.fi (Linus Torvalds)
Date: Tue, 9 Apr 1996 00:24:09 +1000 (EST)
Cc: avalon@coombs.anu.edu.au, linux-kernel@vger.rutgers.edu,
linux-net@vger.rutgers.edu
In-Reply-To: <Pine.LNX.3.91.960408164958.1996D-100000@linux.cs.Helsinki.FI> from "Linus Torvalds" at Apr 8, 96 04:55:16 pm
In some mail from Linus Torvalds, sie said:
>
>
>
> On Mon, 8 Apr 1996, Darren Reed wrote:
> >
> > Consider the case when the packet has an option length of 0 for an
> > option which falls into the "default" case but the packet claims to
> > have (say) 8 bytes of IP options.
>
> Right. Does the lockup go away if you add a test for zero optlen in
> ip_options.c, line 277. Pseudo-patch:
>
> continue;
> }
> optlen = optptr[1];
> - if (l<2 || optlen>l)
> + if (l<2 || optlen>l || !optlen)
> {
> pp_ptr = optptr;
> break;
>
> (or something to that effect..) Does that fix it?
I appears so.
darren
