[2401] in linux-net channel archive
Re: Frozen linux 1.3.84
daemon@ATHENA.MIT.EDU (Linus Torvalds)
Mon Apr 8 10:28:14 1996
Date: Mon, 8 Apr 1996 16:55:16 +0300 (EET DST)
From: Linus Torvalds <torvalds@cs.helsinki.fi>
To: Darren Reed <avalon@coombs.anu.edu.au>
cc: linux-kernel@vger.rutgers.edu, linux-net@vger.rutgers.edu
In-Reply-To: <96Apr8.092834edt.106258-1565+490@vger.rutgers.edu>
On Mon, 8 Apr 1996, Darren Reed wrote:
>
> Consider the case when the packet has an option length of 0 for an
> option which falls into the "default" case but the packet claims to
> have (say) 8 bytes of IP options.
Right. Does the lockup go away if you add a test for zero optlen in
ip_options.c, line 277. Pseudo-patch:
continue;
}
optlen = optptr[1];
- if (l<2 || optlen>l)
+ if (l<2 || optlen>l || !optlen)
{
pp_ptr = optptr;
break;
(or something to that effect..) Does that fix it?
Linus
