[2050] in linux-net channel archive
Re: ICMP redirects do not show up in /proc/net/route?
daemon@ATHENA.MIT.EDU (Malcolm Beattie)
Mon Mar 11 07:16:31 1996
From: Malcolm Beattie <mbeattie@sable.ox.ac.uk>
To: linux-net@vger.rutgers.edu
Date: Mon, 11 Mar 1996 10:17:31 +0000 (GMT)
In-Reply-To: <4gso2v$3af@Q.cistron.nl> from "Miquel van Smoorenburg" at Feb 26, 96 05:45:19 pm
Miquel van Smoorenburg writes:
> I just spend some time on a tool with which I can generate ICMP
> redirects at will.
That reminds me: there's a tiny buglet in net/ipv4/icmp.c of 1.2.13
which seems to have been fixed in 1.3.69 by commenting it out. If it
ever gets uncommented rather than deleted, it may as well be fixed:
Lines 290-292 in 1.2.13 (unindented) are
case ICMP_PROT_UNREACH:
printk(KERN_INFO "ICMP: %s:%d: protocol unreachable.\n",
in_ntoa(iph->daddr), ntohs(iph->protocol));
(1.3.69 has the same at lines 359-361 but with the printk line commented
out). iph->protocol is an unsigned char not a short so the ntohs() makes
the printk log a bogus number.
--Malcolm
--
Malcolm Beattie <mbeattie@sable.ox.ac.uk>
Unix Systems Programmer
Oxford University Computing Services
