[3437] in SIPB_Linux_Development
Re: The installer is fixed
daemon@ATHENA.MIT.EDU (Derek Atkins)
Tue Apr 3 09:31:01 2001
To: Garry Zacheiss <zacheiss@MIT.EDU>
Cc: linux-dev@MIT.EDU
From: Derek Atkins <warlord@MIT.EDU>
Date: 03 Apr 2001 09:30:53 -0400
In-Reply-To: Garry Zacheiss's message of "Tue, 03 Apr 2001 02:56:02 -0400"
Message-ID: <sjmd7aunm9e.fsf@rcn.ihtfp.org>
I've got another (suggested) solution:
1) Do development work in one directory, under RCS or CVS
control (e.g. /mit/linux/devel/redhat/...) Restrict the
ability to commit changes.
2) After a change is tested by the original developer, make
the request to commit. If it's believed that the patch
works, commit the change to CVS.
3) Migrate the change to the AFS installer copy
(e.g. /afs/sipb/system/rhlinux/...)
4) Test the change in AFS.
5) Propagate the change to charon.
This is a slightly more restrictive process that what we used in the
5.2 and previous routines (we sort of skipped step #3/4).
Anyways, this is just a suggestion, and IMHO it will help in the
longer run provided Red Hat doesn't make significant architectural
changes to their installer.
-derek
Garry Zacheiss <zacheiss@MIT.EDU> writes:
> The installer is now fixed, both in afs and on charon. The old
> broken copy is mounted as /afs/sipb/system/rhlinux/redhat-6.2-old. I'll
> remove it when I believe there's nothing else there we care about.
>
> Details:
>
> The change that broke the installer was the change to remove the
> Custom Installer option. I've checked in a more minimal version of the
> same patch that actually works and doesn't completely destroy the
> installer.
>
> This installer consists of the restore that was done from late
> Feburary, with these changes merged back in:
>
> * postinstall changes from jweiss and myself.
>
> * remove custom install option.
>
> * Install 8.4.20.
>
> Changes I've made since then:
>
> * steal code from athena-ws spec file to configure sound card,
> knocking showstopper bug count down to 4.
>
> * Remove gnorpm from package list.
>
> * The postinstall script now saves a copy of install.log in
> /var/athena/install.log.
>
> * /afs/sipb/system/rhlinux/redhat-6.2/RedHat/RPMS/ is now a
> seperate volume, since the single volume was getting too
> big.
>
> * I've made sure we only have a single version of any given
> RPM in the above directory, to prevent people from hurting
> themselves with genhdlist.
>
> I have also removed everyone but myself from system:packs in the
> sipb cell. Before anyone else is added, we need to agree on change
> management procedures.
>
> This is my proposal:
>
> * When making a change to a file in the installer, make
> sure the file is checked into RCS first.
>
> * Make your change, and send mail to linux-dev with the
> diff of your change in unified diff format, along with a
> description of what you think the patch does, and a request
> that the change be pulled up to charon.
>
> **TEST** your changes first. If you don't remember
> the installer's behavior in a specific section, run it
> once *before* making your change.
>
> * Wait for someone to reply saying that your change has
> been propogated to charon and tested there as well. For
> now, I don't want anyone other than Jonathon or myself
> pulling up changes to charon.
>
> The person making the change to charon has an obligation
> to test the installer once the change has been made to
> charon.
>
> If people believe this is reasonable and agree to follow these
> policies, I'm willing to add people back to system:packs -c sipb.
>
> Garry
--
Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
Member, MIT Student Information Processing Board (SIPB)
URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH
warlord@MIT.EDU PGP key available
