[1227] in SIPB_Linux_Development
Comments on rc-athena package
daemon@ATHENA.MIT.EDU (Erik Nygren)
Sun Feb 4 17:32:16 1996
To: sit@MIT.EDU, linux-dev@MIT.EDU
Date: Sun, 04 Feb 1996 17:31:34 -0500
From: Erik Nygren <nygren@MIT.EDU>
Hello,
Just a few (mostly nitpicky) comments on the rc.athena package:
>>>> . /etc/athena/rc.conf
Shouldn't rc.conf be preprocessed in some way? We're not using the
variables that would be affected, but they should either be removed or
corrected. (Maybe just removed?)
Regardless, this should be changed to something like:
ATHENA_RC_CONF=/etc/athena/rc.conf
if [ -f ${ATHENA_RC_CONF} ] ; then
. ${ATHENA_RC_CONF}
else
echo "Couldn't find Athena configuration file ${ATHENA_RC_CONF}."
exit 1
fi
>>>> /etc/athena/gettime -s time
This should be changed to:
/etc/athena/gettime -s $TIMEHUB
or:
/etc/athena/gettime -s time.mit.edu
>>>>>><<<<<
I'm also unconvinced that rc.athena should be in /etc/athena. It (or
at least a symlink to it) really belongs in /etc/rc.d/rc.athena.
That's all I can think of for now.
Erik
