[383] in testers

home help back first fref pref prev next nref lref last post

This bug is not fixed [jik@ATHENA.MIT.EDU: Version 6.3B: /usr/athena/lib/init/login]

daemon@ATHENA.MIT.EDU (daemon@ATHENA.MIT.EDU)
Wed Dec 6 18:29:40 1989

Date: Wed, 6 Dec 89 18:29:12 -0500
From: Jonathan I. Kamens <jik@PIT-MANAGER.MIT.EDU>
To: testers@ATHENA.MIT.EDU

  /usr/athena/lib/init/login still mentions xlogin and NOCALLS, and
still checks for $?prompt.  Either this is a bug that hasn't been
fixed, or somebody came up with a good explanation for why it isn't a
bug and never bothered to explain it to me.

  From the 6.4A /usr/athena/lib/init/login:

# Do not echo status messages if noninteractive shell.  For interactive shells,
# echo messages unless user has ~/.hushlogin file AND the session was not
# started using the xlogin "SYSTEM" option.

if ($?prompt) then
        if ((! -r ~/.hushlogin) || ($?NOCALLS)) set verbose_login
        /bin/stty dec           # Use DEC-style control characters
endif

----- Forwarded message
Date: Sun, 20 Aug 89 18:52:28 -0400
From: Jonathan I. Kamens <jik@ATHENA.MIT.EDU>
Sender: jik@ATHENA.MIT.EDU
To: bugs@ATHENA.MIT.EDU, testers@ATHENA.MIT.EDU
Subject: Version 6.3B: /usr/athena/lib/init/login

System type, version:	Version 6.3B, all platforms

What's wrong:

  The file /usr/athena/lib/init/login contains the following near the
beginning of the file:

# Do not echo status messages if noninteractive shell.  For interactive shells,
# echo messages unless user has ~/.hushlogin file AND the session was not 
# started using the xlogin "SYSTEM" option.

if ($?prompt) then
	if ((! -r ~/.hushlogin) || ($?NOCALLS)) set verbose_login
endif

  /usr/athena/lib/init/login should never be used in an xlogin login,
so the comment about xlogin and the check for NOCALLS are unnecessary.

  Furthermore, I am not convinced the check to see if the shell is
interactive is necessary (although I am not as sure about this).
/usr/athena/lib/init/login should end up getting executed only in an
interactive login shell.

What should have happened:

  The file fragment should read:

# Do not echo status messages if noninteractive shell.  For
# interactive shells, echo messages unless user has ~/.hushlogin file.

if ($?prompt) then
  if (! -r ~/.hushlogin) set verbose_login
endif

  If the check for interactivity is determined not to be necessary,
the fragment should read:

# Echo messages unless user has ~/.hushlogin file.

if (! -r ~/.hushlogin) set verbose_login

  jik
----- End of forwarded message

home help back first fref pref prev next nref lref last post