[28431] in Source-Commits
Re: scripts commit: Further noninteractive enhancements
daemon@ATHENA.MIT.EDU (Jonathan D Reed)
Tue Sep 16 12:32:37 2014
From: Jonathan D Reed <jdreed@mit.edu>
To: Benjamin J Kaduk <kaduk@mit.edu>
CC: "source-commits@MIT.EDU" <source-commits@mit.edu>
Date: Tue, 16 Sep 2014 16:32:26 +0000
Message-ID: <28536CA9-B574-4C92-8D52-2C15C5D3B2BE@mit.edu>
In-Reply-To: <alpine.GSO.1.10.1409161221130.21571@multics.mit.edu>
Content-Language: en-US
Content-Type: multipart/alternative;
boundary="_000_28536CA9B5744C928D522C15C5D3B2BEmitedu_"
MIME-Version: 1.0
--_000_28536CA9B5744C928D522C15C5D3B2BEmitedu_
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
Hrm, you=92re right. I will fix that in my copy and check it back in with =
more changes later. But yes, installing cluster interactively has always b=
een firmly in =93don=92t do that=94 territory.
-Jon
On Sep 16, 2014, at 12:22 PM, Benjamin Kaduk <kaduk@MIT.EDU<mailto:kaduk@MI=
T.EDU>> wrote:
On Tue, 16 Sep 2014, Jonathan D Reed wrote:
https://github.com/mit-athena/scripts/commit/e1ee0054a2cdd392e98ed37035967c=
3c890cca1f
commit e1ee0054a2cdd392e98ed37035967c3c890cca1f
Author: Jonathan Reed <jdreed@mit.edu>
Date: Mon Sep 15 15:02:05 2014 -0400
Further noninteractive enhancements
Ensure that the msmtp-mta prompt is only displayed for
interactive installs, and that the defaults are sane.
installer/install-debathena.beta.sh | 28 ++++++++++++++++++----------
1 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/installer/install-debathena.beta.sh b/installer/install-debath=
ena.beta.sh
index 20b15e6..38f0bca 100644
--- a/installer/install-debathena.beta.sh
+++ b/installer/install-debathena.beta.sh
@@ -178,23 +178,30 @@ mainpackage=3Ddebathena-$category
csoft=3Dno
tsoft=3Dno
resolvconfhack=3Dno
-msmtpmta=3Dno
-if [ cluster =3D "$category" ]; then
- msmtpmta=3Dyes
-else
+case "$category" in
+ cluster)
+ msmtpmta=3Dyes
I think this would result in an attended cluster install getting a
not-very-helpful prompt about debathena-msmtp-mta, but I think we assume
that your pointy hat is pretty tall if you're doing that, so it doesn't
seem like a real issue.
-Ben
+ ;;
+ workstation)
+ msmtpmta=3Dyes
+ maildefault=3Dy
+ mailprompt=3D"[Y/n]"
+ ;;
+ *)
+ msmtpmta=3Dno
+ maildefault=3Dn
+ mailprompt=3D"[y/N]"
+ ;;
+esac
--_000_28536CA9B5744C928D522C15C5D3B2BEmitedu_
Content-Type: text/html; charset="Windows-1252"
Content-ID: <42A872D557F9CD4DA00FFEF3B3AF3543@exchange.mit.edu>
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DWindows-1=
252">
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-lin=
e-break: after-white-space;">
Hrm, you=92re right. I will fix that in my copy and check it back in =
with more changes later. But yes, installing cluster interactively ha=
s always been firmly in =93don=92t do that=94 territory.
<div><br>
</div>
<div>-Jon</div>
<div><br>
<div>
<div>On Sep 16, 2014, at 12:22 PM, Benjamin Kaduk <<a href=3D"mailto:kad=
uk@MIT.EDU">kaduk@MIT.EDU</a>> wrote:</div>
<br class=3D"Apple-interchange-newline">
<blockquote type=3D"cite">
<div style=3D"font-size: 12px; font-style: normal; font-variant: normal; fo=
nt-weight: normal; letter-spacing: normal; line-height: normal; orphans: au=
to; text-align: start; text-indent: 0px; text-transform: none; white-space:=
normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
On Tue, 16 Sep 2014, Jonathan D Reed wrote:<br>
<br>
<blockquote type=3D"cite"><a href=3D"https://github.com/mit-athena/scripts/=
commit/e1ee0054a2cdd392e98ed37035967c3c890cca1f">https://github.com/mit-ath=
ena/scripts/commit/e1ee0054a2cdd392e98ed37035967c3c890cca1f</a><br>
commit e1ee0054a2cdd392e98ed37035967c3c890cca1f<br>
Author: Jonathan Reed <jdreed@mit.edu><br>
Date: Mon Sep 15 15:02:05 2014 -0400<br>
<br>
Further noninteractive enhancements<br>
<br>
Ensure that the msmtp-mta prompt is only displayed for<br=
>
interactive installs, and that the defaults are sane.<br>
<br>
installer/install-debathena.beta.sh | 28 ++++&#=
43;+++++++++++++-------=
---<br>
1 files changed, 18 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/installer/install-debathena.beta.sh b/installer/install-debath=
ena.beta.sh<br>
index 20b15e6..38f0bca 100644<br>
--- a/installer/install-debathena.beta.sh<br>
+++ b/installer/install-debathena.beta.sh<br>
@@ -178,23 +178,30 @@ mainpackage=3Ddebathena-$category<br>
csoft=3Dno<br>
tsoft=3Dno<br>
resolvconfhack=3Dno<br>
-msmtpmta=3Dno<br>
<br>
-if [ cluster =3D "$category" ]; then<br>
- msmtpmta=3Dyes<br>
-else<br>
+case "$category" in<br>
+ cluster)<br>
+ msmtpmta=3Dyes<br>
</blockquote>
<br>
I think this would result in an attended cluster install getting a<br>
not-very-helpful prompt about debathena-msmtp-mta, but I think we assume<br=
>
that your pointy hat is pretty tall if you're doing that, so it doesn't<br>
seem like a real issue.<br>
<br>
-Ben<br>
<br>
<blockquote type=3D"cite">+ ;;<br>
+ workstation)<br>
+ msmtpmta=3Dyes<br>
+ maildefault=3Dy<br>
+ mailprompt=3D"[Y/n]"<br>
+ ;;<br>
+ *)<br>
+ msmtpmta=3Dno<br>
+ maildefault=3Dn<br>
+ mailprompt=3D"[y/N]"<br>
+ ;;<br>
+esac</blockquote>
</div>
</blockquote>
</div>
<br>
</div>
</body>
</html>
--_000_28536CA9B5744C928D522C15C5D3B2BEmitedu_--