[28430] in Source-Commits
Re: scripts commit: Further noninteractive enhancements
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Tue Sep 16 12:22:39 2014
Date: Tue, 16 Sep 2014 12:22:26 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201409161448.s8GEm2Df002930@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1409161221130.21571@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
On Tue, 16 Sep 2014, Jonathan D Reed wrote:
> https://github.com/mit-athena/scripts/commit/e1ee0054a2cdd392e98ed37035967c3c890cca1f
> commit e1ee0054a2cdd392e98ed37035967c3c890cca1f
> Author: Jonathan Reed <jdreed@mit.edu>
> Date: Mon Sep 15 15:02:05 2014 -0400
>
> Further noninteractive enhancements
>
> Ensure that the msmtp-mta prompt is only displayed for
> interactive installs, and that the defaults are sane.
>
> installer/install-debathena.beta.sh | 28 ++++++++++++++++++----------
> 1 files changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/installer/install-debathena.beta.sh b/installer/install-debathena.beta.sh
> index 20b15e6..38f0bca 100644
> --- a/installer/install-debathena.beta.sh
> +++ b/installer/install-debathena.beta.sh
> @@ -178,23 +178,30 @@ mainpackage=debathena-$category
> csoft=no
> tsoft=no
> resolvconfhack=no
> -msmtpmta=no
>
> -if [ cluster = "$category" ]; then
> - msmtpmta=yes
> -else
> +case "$category" in
> + cluster)
> + msmtpmta=yes
I think this would result in an attended cluster install getting a
not-very-helpful prompt about debathena-msmtp-mta, but I think we assume
that your pointy hat is pretty tall if you're doing that, so it doesn't
seem like a real issue.
-Ben
> + ;;
> + workstation)
> + msmtpmta=yes
> + maildefault=y
> + mailprompt="[Y/n]"
> + ;;
> + *)
> + msmtpmta=no
> + maildefault=n
> + mailprompt="[y/N]"
> + ;;
> +esac
