[26689] in Source-Commits
Re: /svn/athena r25687 - in trunk/athena/etc/athinfod: . debian
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Thu Aug 2 19:25:31 2012
In-Reply-To: <alpine.GSO.1.10.1208021910150.22690@multics.mit.edu>
Mime-Version: 1.0 (1.0)
Content-Type: text/plain;
charset=us-ascii
Message-Id: <38B8FC06-62B4-4EE3-AF83-D7099A280A4F@mit.edu>
Cc: "source-commits@MIT.EDU" <source-commits@MIT.EDU>
From: Jonathan Reed <jdreed@MIT.EDU>
Date: Thu, 2 Aug 2012 19:25:26 -0400
To: Benjamin Kaduk <kaduk@MIT.EDU>
Content-Transfer-Encoding: 8bit
On Aug 2, 2012, at 7:16 PM, Benjamin Kaduk <kaduk@MIT.EDU> wrote:
> On Thu, 2 Aug 2012, Jonathan Reed wrote:
>
>> Hrm, good point. I wonder whether it's preferable to have a giant for loop in the queries file, or what. Or just cat /etc/athena/athinfo.defs.d/*.defs 2>/dev/null ?
>>
>> Or maybe athinfo itself should answer queries internally? Though that seems like more effort than it's worth. I think I'm leaning towards:
>>
>> queries cat /etc/athena/athinfo.defs && cat /etc/athena/athinfo.defs.d/*.defs 2>/dev/null
>
> -10 points, unnecessary use of cat(1).
> (Though to be fair, tcsh will just bail if the glob fails, but dash seems to do the right thing with cat athinfo.defs athinfo.d/*.defs 2>/dev/null)
Derp, I have no idea what I was thinking. But, grep -v ^# or something is probably useful.
> Though, hmm, I guess it should properly be just * and not *.defs, and really we should be filterting out the comments with one of those grep invocations that Anders is quick with and I never remember.
>
> -Ben
>
>>
>>
>> On Aug 2, 2012, at 6:40 PM, Jonathon Weiss wrote:
>>
>>>
>>> You also need to update the athinfo queries query
>>>
>>> --
>>>
>>> Jonathon
>>>
>>>
>>>
>>> Jonathan D Reed <jdreed@MIT.EDU> wrote:
>>>
>>>> Author: jdreed
>>>> Date: 2012-08-02 16:29:47 -0400 (Thu, 02 Aug 2012)
>>>> New Revision: 25687
>>>>
>>>> Modified:
>>>> trunk/athena/etc/athinfod/athinfo.access.5
>>>> trunk/athena/etc/athinfod/athinfo.defs.5
>>>> trunk/athena/etc/athinfod/athinfod.c
>>>> trunk/athena/etc/athinfod/debian/changelog
>>>> Log:
>>>> In athinfod:
>>>> * Support athinfo.defs.d (Trac: #808)
>>>> * Correct typos in athinfo.access(5)
>>
>>
