[26688] in Source-Commits
Re: /svn/athena r25687 - in trunk/athena/etc/athinfod: . debian
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Thu Aug 2 19:16:38 2012
Date: Thu, 2 Aug 2012 19:16:35 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <F513F0AD-87BA-4191-8CAB-7BD01103621C@mit.edu>
Message-ID: <alpine.GSO.1.10.1208021910150.22690@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
On Thu, 2 Aug 2012, Jonathan Reed wrote:
> Hrm, good point. I wonder whether it's preferable to have a giant for loop in the queries file, or what. Or just cat /etc/athena/athinfo.defs.d/*.defs 2>/dev/null ?
>
> Or maybe athinfo itself should answer queries internally? Though that seems like more effort than it's worth. I think I'm leaning towards:
>
> queries cat /etc/athena/athinfo.defs && cat
> /etc/athena/athinfo.defs.d/*.defs 2>/dev/null
-10 points, unnecessary use of cat(1).
(Though to be fair, tcsh will just bail if the glob fails, but dash seems
to do the right thing with cat athinfo.defs athinfo.d/*.defs 2>/dev/null)
Though, hmm, I guess it should properly be just * and not *.defs, and
really we should be filterting out the comments with one of those grep
invocations that Anders is quick with and I never remember.
-Ben
>
>
> On Aug 2, 2012, at 6:40 PM, Jonathon Weiss wrote:
>
>>
>> You also need to update the athinfo queries query
>>
>> --
>>
>> Jonathon
>>
>>
>>
>> Jonathan D Reed <jdreed@MIT.EDU> wrote:
>>
>>> Author: jdreed
>>> Date: 2012-08-02 16:29:47 -0400 (Thu, 02 Aug 2012)
>>> New Revision: 25687
>>>
>>> Modified:
>>> trunk/athena/etc/athinfod/athinfo.access.5
>>> trunk/athena/etc/athinfod/athinfo.defs.5
>>> trunk/athena/etc/athinfod/athinfod.c
>>> trunk/athena/etc/athinfod/debian/changelog
>>> Log:
>>> In athinfod:
>>> * Support athinfo.defs.d (Trac: #808)
>>> * Correct typos in athinfo.access(5)
>
>
