[26542] in Source-Commits
Re: /svn/athena r25610 -
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Wed Jul 4 21:50:03 2012
Date: Wed, 4 Jul 2012 21:50:01 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <4924EEC0-4301-43E9-B02A-0F14DDE7DEF8@MIT.EDU>
Message-ID: <alpine.GSO.1.10.1207042148170.18441@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Wed, 4 Jul 2012, Jonathan Reed wrote:
>>
>> We need to run after the debhelper rule in order to check HAVE_ICEDTEA?
>
> No, but we do need it to append to the install rule. The packages
> conditional dependencies worked; its conditional dh_install for the
> ooffice helper didn't. I moved it to the top of the package for
Ah, that makes much more sense. I would complain that it wasn't in the
diff in the mail, but I was looking at the actual source file; I guess I
was just blind.
> clarity. It can't hurt to sanity-check, but I think we would have
> noticed if other packages were broken. Perhaps that's overly
> optimistic, though.
I think we don't have many direct calls to dh_install (and friends), so
we're probably okay. (My grep, modified for dh_install instead of
binary-predeb, finds nothing.)
-Ben
