[26541] in Source-Commits
Re: /svn/athena r25610 - trunk/debathena/meta/extra-software/debian
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Wed Jul 4 21:46:33 2012
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <alpine.GSO.1.10.1207042002520.18441@multics.mit.edu>
Date: Wed, 4 Jul 2012 21:46:29 -0400
Cc: source-commits@MIT.EDU
Message-Id: <4924EEC0-4301-43E9-B02A-0F14DDE7DEF8@MIT.EDU>
To: Benjamin Kaduk <kaduk@MIT.EDU>
Content-Transfer-Encoding: 8bit
>
> We need to run after the debhelper rule in order to check HAVE_ICEDTEA?
No, but we do need it to append to the install rule. The packages conditional dependencies worked; its conditional dh_install for the ooffice helper didn't. I moved it to the top of the package for clarity. It can't hurt to sanity-check, but I think we would have noticed if other packages were broken. Perhaps that's overly optimistic, though.
-Jon
> Perhaps we want to audit some other packages...
> find . -type f -name rules | xargs grep -l binary-predeb|xargs grep -A2 debhelper.mk
> and looking for entries with only a single line of output (i.e., debhelper.mk is included as the last line of rules) finds:
> gdm-config
> thirdparty-graphics
> login-graphical
> clients
> thirdparty-{utilities,libraries,programming,text}
> workstation
> extra-software-nox
>
> I'll ACK this commit for now.
>
> -Ben
