[25824] in Source-Commits
Re: /svn/athena r25241 -
daemon@ATHENA.MIT.EDU (Geoffrey Thomas)
Sun Jul 17 14:48:26 2011
Date: Sun, 17 Jul 2011 14:48:19 -0400 (EDT)
From: Geoffrey Thomas <geofft@MIT.EDU>
To: Benjamin Kaduk <kaduk@mit.edu>
cc: source-commits@mit.edu
In-Reply-To: <alpine.GSO.1.10.1107162039110.6818@multics.mit.edu>
Message-ID: <alpine.DEB.2.00.1107162040360.8101@tyger.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Sat, 16 Jul 2011, Benjamin Kaduk wrote:
> On Sat, 16 Jul 2011, Geoffrey Thomas wrote:
>
>> Author: geofft
>> Date: 2011-07-16 10:54:14 -0400 (Sat, 16 Jul 2011)
>> New Revision: 25241
>>
>> Modified:
>> trunk/debathena/scripts/installer/pxe/stage1/debathena/installer.sh
>> Log:
>> installer: Quote moar
>>
>> Modified:
>> trunk/debathena/scripts/installer/pxe/stage1/debathena/installer.sh
>> ===================================================================
>> --- trunk/debathena/scripts/installer/pxe/stage1/debathena/installer.sh
>> 2011-07-16 14:20:24 UTC (rev 25240)
>> +++ trunk/debathena/scripts/installer/pxe/stage1/debathena/installer.sh
>> 2011-07-16 14:54:14 UTC (rev 25241)
>> @@ -25,7 +25,7 @@
>> # First make sure we're talking to who we think we are
>> havedns=n
>> ipprompt="Enter IP address:"
>> - if [ "$(wget -qO - $dnscgi"/q")" = "Debathena DNS-CGI" ]; then
>> + if [ "$(wget -qO - "$dnscgi/q")" = "Debathena DNS-CGI" ]; then
>
> Should we also make a pass to use braces for variable expansion?
It's unclear to me this is particularly helpful -- that's a function of
variable _name_, which you can see right in the script, whereas quoting
is about variable _contents_ (which admittedly are mostly there in the
script, but are much more... variable... and prone to getting funny
characters eventually in ways that identifiers aren't).
