[25823] in Source-Commits
Re: /svn/athena r25241 -
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Sat Jul 16 20:39:46 2011
Date: Sat, 16 Jul 2011 20:39:37 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Geoffrey Thomas <geofft@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201107161454.p6GEsFdb004782@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1107162039110.6818@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Sat, 16 Jul 2011, Geoffrey Thomas wrote:
> Author: geofft
> Date: 2011-07-16 10:54:14 -0400 (Sat, 16 Jul 2011)
> New Revision: 25241
>
> Modified:
> trunk/debathena/scripts/installer/pxe/stage1/debathena/installer.sh
> Log:
> installer: Quote moar
>
> Modified: trunk/debathena/scripts/installer/pxe/stage1/debathena/installer.sh
> ===================================================================
> --- trunk/debathena/scripts/installer/pxe/stage1/debathena/installer.sh 2011-07-16 14:20:24 UTC (rev 25240)
> +++ trunk/debathena/scripts/installer/pxe/stage1/debathena/installer.sh 2011-07-16 14:54:14 UTC (rev 25241)
> @@ -25,7 +25,7 @@
> # First make sure we're talking to who we think we are
> havedns=n
> ipprompt="Enter IP address:"
> - if [ "$(wget -qO - $dnscgi"/q")" = "Debathena DNS-CGI" ]; then
> + if [ "$(wget -qO - "$dnscgi/q")" = "Debathena DNS-CGI" ]; then
Should we also make a pass to use braces for variable expansion?
-Ben
