[1471] in Moira

home help back first fref pref prev next nref lref last post

Re: moira client crashing on Windows

daemon@ATHENA.MIT.EDU (Qing Dong)
Wed Mar 22 14:40:30 2000

Message-Id: <200003221940.OAA03420@melbourne-city-street.MIT.EDU>
Date: Wed, 22 Mar 2000 14:40:26 -0500
To: moiradev@mit.edu
From: Qing Dong <dongq@MIT.EDU>
In-Reply-To: <200003220014.TAA28113@sweet-transvestite.mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

A patch to fix moira crashing under Windows:

Index: user.c
===================================================================
RCS file:
\\dongq-afs\all\athena.mit.edu\astaff\project\moiradev\repository/moira/clie
nts/moira/user.c,v
retrieving revision 1.58
diff -c -r1.58 user.c
*** user.c	2000/03/15 22:44:06	1.58
--- user.c	2000/03/22 19:34:03
***************
*** 558,563 ****
--- 558,567 ----
    char temp_buf[BUFSIZ];
    int status;
  
+   int i;
+   for (i = 0; i < MAX_ARGS_SIZE; i++)
+ 	  args[i] = NULL;
+ 
    Put_message("This function has NO kerberos support, so strange things");
    Put_message("may happen if you use it to register a user.");

At 07:14 PM 3/21/2000 -0500, Garry Zacheiss wrote:
>>> I am looking at the latest registeruser changes to incorporate them into
>>> pismere moira gui client. I encountered a crash when I tried to register
>>> a user. I entered "?" when prompted P.O box type and it crashed in the
>>> FreeInfo() call inside RegisterUser() in user.c
>
>   I assume it was under Windows that you were seeing this crash,
>because I can't reproduce it on Solaris.  Your solution sounds fine,
>though; feel free to submit a patch.
>
>Garry
> 


home help back first fref pref prev next nref lref last post