[6154] in Athena Bugs
Re: code confusion in rpc.mountd.c
daemon@ATHENA.MIT.EDU (Richard Basch)
Tue Oct 2 14:53:52 1990
Date: Tue, 2 Oct 90 14:53:29 -0400
To: jtkohl@MIT.EDU, bugs@ATHENA.MIT.EDU
In-Reply-To: bugs[6153]
From: Richard Basch <probe@MIT.EDU>
You are indeed correct... it should be using svcerr_auth(), not
svcerr_weakauth(). svcerr_weakauth() is a function that calls
svcerr_auth() with the "why" as WEAKAUTH.
Fixed in 7.2
-Richard
[6153] daemon@ATHENA.MIT.EDU Athena Bugs 10/02/90 13:35 (20 lines)
Subject: code confusion in rpc.mountd.c
Date: Tue, 2 Oct 90 13:34:47 -0400
From: John T Kohl <jtkohl@ATHENA.MIT.EDU>
To: bugs@ATHENA.MIT.EDU
/source/bsd-4.3/common/usr.etc/rpc.mountd/rpc.mountd.c,
in the function imposter():
There are two different uses of the function svcerr_weakauth(); the
second has an extra argument.
There's also some confusion here about return values; if a non-zero
value is returned, svcerr_weakauth() is called by the caller and the
connection is rejected.
Someone should examine this code; I suspect the svcerr_ calls in
imposter() want to set some error code in the transport structure, and
let the caller reflect the error to the network client.
John
--[6153]--
