[6153] in Athena Bugs

home help back first fref pref prev next nref lref last post

code confusion in rpc.mountd.c

daemon@ATHENA.MIT.EDU (John T Kohl)
Tue Oct 2 13:35:01 1990

Date: Tue, 2 Oct 90 13:34:47 -0400
From: John T Kohl <jtkohl@ATHENA.MIT.EDU>
To: bugs@ATHENA.MIT.EDU

/source/bsd-4.3/common/usr.etc/rpc.mountd/rpc.mountd.c,
in the function imposter():

There are two different uses of the function svcerr_weakauth(); the
second has an extra argument.

There's also some confusion here about return values; if a non-zero
value is returned, svcerr_weakauth() is called by the caller and the
connection is rejected.

Someone should examine this code; I suspect the svcerr_ calls in
imposter() want to set some error code in the transport structure, and
let the caller reflect the error to the network client.

John


home help back first fref pref prev next nref lref last post