[6078] in Athena Bugs

home help back first fref pref prev next nref lref last post

vax 7.1H: attach

daemon@ATHENA.MIT.EDU (vanharen@ATHENA.MIT.EDU)
Thu Sep 20 15:59:23 1990

From: vanharen@ATHENA.MIT.EDU
To: bugs@ATHENA.MIT.EDU
Cc: wdc@ATHENA.MIT.EDU
Date: Thu, 20 Sep 90 15:58:58 EDT

System name:		fries
Type and version:	CVAXSTAR 7.1H (2 update(s) to same version)
Display type:		SM

What were you trying to do?
	attach a filesystem

What's wrong:
	attach gave me an error, but did not give much information about
	what failed or why.  The error message "attach: you are not
	allowed to attach a filesystem here" is not very helpful.

What should have happened:
	It should at least say what I was trying to attach that failed,
	and possibly where it was trying to attach.  Perhaps this is
	more a feature request than a bug report, but that's
	questionable.

	On another note, whenever "attach" prints out the filsys name,
	it would be nice if it were delimited by single or double
	quotes.  This is more a feature request than a bug report.

Reproduce by:
	% attach nandrew
	attach: /afs/athena/astaff/project/andrew/nexport linked to
            /mit/andrew for filesystem nandrew
	% attach andrew
	attach: You are not allowed to attach a filesystem here

(Simple) Fix:
	Apply the following patch to get it to print out the filsys
	name.  To get it to print out the mount point would take a bit
	more re-arranging of the source.  If I get the chance, I may
	send that in later.
==============================================================================
*** /source/athena/bin.athena/attach/attach.c	Wed Aug  1 18:12:02 1990
--- /tmp/attach.c	Thu Sep 20 15:52:46 1990
***************
*** 189,196 ****
  
      if (error_status == ERR_ATTACHBADMNTPT)
  	    fprintf(stderr,
! 		    "%s: You are not allowed to attach a filesystem here\n",
! 		    progname);
      /*
       * We've failed -- delete the partial entry and unlock the in-use file.
       */
--- 189,196 ----
  
      if (error_status == ERR_ATTACHBADMNTPT)
  	    fprintf(stderr,
! 		    "%s: You are not allowed to attach filesystem %s here\n",
! 		    progname, name);
      /*
       * We've failed -- delete the partial entry and unlock the in-use file.
       */

home help back first fref pref prev next nref lref last post