[5650] in Athena Bugs
rkinit bug fix
daemon@ATHENA.MIT.EDU (qjb@ATHENA.MIT.EDU)
Wed Aug 1 11:57:21 1990
From: qjb@ATHENA.MIT.EDU
Date: Wed, 1 Aug 90 11:56:58 -0400
To: testers@ATHENA.MIT.EDU, bugs@ATHENA.MIT.EDU
Cc: dkk@ATHENA.MIT.EDU
The following patches fix this bug reported by dkk:
> At least in VS7.1C:
>
> When an incorrect password is typed to rkinit, the daemon (rkinitd)
> syslogs an error as "user.error". This should either not happen at
> all, or it should happen at debug priority.
==== patch to be applied in rkinit/lib ====
*** rk_rpc.c.old Wed Aug 1 11:54:17 1990
--- rk_rpc.c Wed Aug 1 11:53:22 1990
***************
*** 1,5 ****
/*
! * $Id: rk_rpc.c,v 1.4 90/07/16 14:15:31 qjb Exp $
* $Source: /afs/athena.mit.edu/user/q/qjb/source/rkinit/lib/RCS/rk_rpc.c,v $
* $Author: qjb $
*
--- 1,5 ----
/*
! * $Id: rk_rpc.c,v 1.5 90/08/01 11:53:04 qjb Exp $
* $Source: /afs/athena.mit.edu/user/q/qjb/source/rkinit/lib/RCS/rk_rpc.c,v $
* $Author: qjb $
*
***************
*** 9,15 ****
*/
#if !defined(lint) && !defined(SABER) && !defined(LOCORE) && defined(RCS_HDRS)
! static char *rcsid = "$Id: rk_rpc.c,v 1.4 90/07/16 14:15:31 qjb Exp $";
#endif /* lint || SABER || LOCORE || RCS_HDRS */
#include <stdio.h>
--- 9,15 ----
*/
#if !defined(lint) && !defined(SABER) && !defined(LOCORE) && defined(RCS_HDRS)
! static char *rcsid = "$Id: rk_rpc.c,v 1.5 90/08/01 11:53:04 qjb Exp $";
#endif /* lint || SABER || LOCORE || RCS_HDRS */
#include <stdio.h>
***************
*** 137,143 ****
}
if (packet[PKT_TYPE] == MT_DROP) {
! sprintf(errbuf, "Connection dropped by remote host");
rkinit_errmsg(errbuf);
return(RKINIT_DROPPED);
}
--- 137,143 ----
}
if (packet[PKT_TYPE] == MT_DROP) {
! BCLEAR(errbuf);
rkinit_errmsg(errbuf);
return(RKINIT_DROPPED);
}
==== patch to be applied in rkinit/rkinitd ====
*** rkinitd.c.old Wed Aug 1 11:56:33 1990
--- rkinitd.c Wed Aug 1 11:56:24 1990
***************
*** 1,5 ****
/*
! * $Id: rkinitd.c,v 1.2 90/07/16 14:16:34 qjb Exp $
* $Source: /afs/athena.mit.edu/user/q/qjb/source/rkinit/rkinitd/RCS/rkinitd.c,v $
* $Author: qjb $
*
--- 1,5 ----
/*
! * $Id: rkinitd.c,v 1.3 90/08/01 11:56:13 qjb Exp $
* $Source: /afs/athena.mit.edu/user/q/qjb/source/rkinit/rkinitd/RCS/rkinitd.c,v $
* $Author: qjb $
*
***************
*** 7,13 ****
*/
#if !defined(lint) && !defined(SABER) && !defined(LOCORE) && defined(RCS_HDRS)
! static char *rcsid = "$Id: rkinitd.c,v 1.2 90/07/16 14:16:34 qjb Exp $";
#endif /* lint || SABER || LOCORE || RCS_HDRS */
#include <stdio.h>
--- 7,13 ----
*/
#if !defined(lint) && !defined(SABER) && !defined(LOCORE) && defined(RCS_HDRS)
! static char *rcsid = "$Id: rkinitd.c,v 1.3 90/08/01 11:56:13 qjb Exp $";
#endif /* lint || SABER || LOCORE || RCS_HDRS */
#include <stdio.h>
***************
*** 56,65 ****
char errbuf[BUFSIZ];
strcpy(errbuf, rkinit_errmsg(0));
! if (inetd)
! syslog(LOG_ERR, "rkinitd: %s", errbuf);
! else
! fprintf(stderr, "rkinitd: %s\n", errbuf);
}
#ifdef __STDC__
--- 56,67 ----
char errbuf[BUFSIZ];
strcpy(errbuf, rkinit_errmsg(0));
! if (strlen(errbuf)) {
! if (inetd)
! syslog(LOG_ERR, "rkinitd: %s", errbuf);
! else
! fprintf(stderr, "rkinitd: %s\n", errbuf);
! }
}
#ifdef __STDC__
