[4344] in Athena Bugs
Re: RT 6.4R: inc [no warning when over quota?]
daemon@ATHENA.MIT.EDU (Ken Raeburn)
Wed Feb 28 11:21:34 1990
Date: Wed, 28 Feb 90 11:21:10 -0500
From: Ken Raeburn <Raeburn@ATHENA.MIT.EDU>
To: bugs@ATHENA.MIT.EDU
In-Reply-To: Carla Fermann's message of Wed, 28 Feb 90 10:13:37 EST,
I put in some of those changes myself; not thorough enough, I guess...
At 534 in uip/inc.c, an fflush is followed by an fseek. An error from
writing the file (especially to AFS) won't necessarily be returned
here. Someone should investigate the fsync call to see whether NFS
and AFS write errors are guaranteed to be returned here; if so, an
fsync should be done here; if not, the file should be closed and
re-opened, with error checking done on both operations. (I believe
this is the cause of the problem in this bug report.)
(I experimented with AFS and fsync at one point; I believe it is the
case that if fsync returns an error, then close may not necessarily do
so, if no additional write calls are made. But I'm not certain.)
Similar changes should be made in the non-POP version immediately
preceding, but that's less critical for Athena.
