[16116] in Athena Bugs
ftp client problem in 8.2
daemon@ATHENA.MIT.EDU (Tom Yu)
Fri Aug 7 01:53:10 1998
Date: Fri, 7 Aug 1998 01:53:06 -0400
To: danw@MIT.EDU
Cc: sly@MIT.EDU, bugs@MIT.EDU
From: Tom Yu <tlyu@MIT.EDU>
I traced down the ftp client problem when using an athena 8.2 ftp
client to connect to a CNS krb4 ftpd. Basically it was using
krb_rd_safe regardless of whether the server reply message was a
krb_safe or a krb_priv. This resulted in the "wrong message type"
error. The following patch should fix it. In any case, it was a bug
introduced during some cleanup of the ftp client between CNS and krb5,
probably due to someone thinking that the construct "safe = code ==
631" looked bogus. I've reinstated that code, parenthesized for
greater obviousness. I will check this into the krb5 tree soon.
---Tom
Index: ftp.c
===================================================================
RCS file: /cvs/krbdev/krb5/src/appl/gssftp/ftp/ftp.c,v
retrieving revision 1.14
diff -u -r1.14 ftp.c
--- ftp.c 1998/01/30 00:57:02 1.14
+++ ftp.c 1998/08/07 05:46:49
@@ -597,7 +597,7 @@
if (code != 631 && code != 632 && code != 633) {
printf("Unknown reply: %d %s\n", code, obuf);
n = '5';
- } else safe = code;
+ } else safe = (code == 631);
if (obuf[0]) /* if there is a string to decode */
if (!auth_type) {
printf("Cannot decode reply:\n%d %s\n", code, obuf);
