[14306] in Athena Bugs
telnetd: spurious "You must use the encryption option"
daemon@ATHENA.MIT.EDU (ghudson@MIT.EDU)
Fri Apr 12 15:07:52 1996
From: ghudson@MIT.EDU
Date: Fri, 12 Apr 1996 15:07:47 -0400
To: brlewis@MIT.EDU, bugs@MIT.EDU
Cc:
I've incorporated this patch into the release. I ran into one semantic
problem with the patch: each time it calls ttloop(), it resets the alarm
to five seconds, so that if the client keeps sending input once every
five seconds (for whatever reason), it might wait forever before forking
login. I changed it to set a five-second alarm once before the loop.
I also had some stylistic gripes with your patch: you did not ues the
same identation and brace style as the surrounding code, and you declared
global variables in the middle of code files when there was already
a section at the top of the file for global variables. Regardless of
your or my personal preferences on how to do these things, it makes C
code harder to read when they are done inconsistently.
I apologize for not noticing these quibbles during auditing.
