[52] in bug-owl
Extraneous zlog functions
daemon@ATHENA.MIT.EDU (Mitchell E Berger)
Fri Jul 5 15:30:28 2002
Message-Id: <200207051930.PAA17720@athenaphobia.mit.edu>
To: bug-owl@MIT.EDU
Date: Fri, 05 Jul 2002 15:30:26 -0400
From: Mitchell E Berger <mitchb@MIT.EDU>
A while ago, I had noticed that though it was claimed owl would respect your
visibility setting when doing a 'zlog in', the zlog_in() function seemed to
always use EXPOSE_NETVIS as the visibility level. Upon closer inspection of
CVS, it seems to be the case that the following functions exist and are never
used:
owl_command_zlog_out() in commands.c
zlog_in() in zephyr.c
zlog_out() in zephyr.c
Both commands are handled by owl_command_zlog(), and the actual call to
ZSetLocation() or ZUnsetLocation() is made from owl_function_zlog_in() or
owl_function_zlog_out(). We should probably get rid of the three functions
above, because they're unused and are only going to confuse someone and add
a small amount of bloat to the binary, but it might be cleaner (especially if
we're going to have multiple protocols supported) if the real work was moved
into zephyr.c rather than functions.c.
Mitch
