[365] in bug-owl
Re: load-subs doesn't print errors
daemon@ATHENA.MIT.EDU (James M. Kretchmar)
Mon Jan 3 22:44:19 2005
Message-Id: <200501040344.j043i9Oo010171@paddington.mit.edu>
To: "Arun A. Tharuvai" <aat@alum.MIT.EDU>
cc: bug-owl@ktools.org
In-Reply-To: Your message of "Thu, 12 Aug 2004 23:12:58 EDT."
<Pine.GSO.4.55L.0408122257570.20690@multics.mit.edu>
Date: Mon, 03 Jan 2005 22:44:08 -0500
From: "James M. Kretchmar" <kretch@MIT.EDU>
I've taken the patch for 2.1.11 (the next owl-beta to be released) but
I also added some other code.
I didn't want users without a .zephyr.subs to get an error message on
login, or on using 'load-subs' without an argument (which can be used
to reload default zephyr subscriptions). In retrospect load-subs
should probably require an argument, or the different functionalities
should be placed in two separate commands.
At any rate, the behavior for 2.1.11 will be:
load-subs will always report an error if loading a file that exists
but is unreadable.
load-subs will report an error if given an explicit filename that
does not exist.
load-subs will NOT report an error if not given a filename and the
default .zephyr.subs does not exist. However, the success message
is somewhat different in this case.
Hopefully that addresses most of your problem. If you have ideas for
a better interface for all this I'm open to suggestions.
kretch
> [0347] daemon@ATHENA.MIT.EDU (Arun A. Tharuvai) bug-owl 08/12/04 23:13 (43 lines)
> Subject: load-subs doesn't print errors
> Date: Thu, 12 Aug 2004 23:12:58 -0400 (EDT)
> From: "Arun A. Tharuvai" <aat@alum.MIT.EDU>
> Reply-To: "Arun A. Tharuvai" <aat@alum.MIT.EDU>
> To: bug-owl@ktools.org
> cc: aat@alum.MIT.EDU
> Message-ID: <Pine.GSO.4.55L.0408122257570.20690@multics.mit.edu>
> MIME-Version: 1.0
> Content-Type: MULTIPART/MIXED; BOUNDARY="-559023410-1836660416-1092366778=:20690"
>
> This message is in MIME format. The first part should be readable text,
> while the remaining parts are likely unreadable without MIME-aware tools.
> Send mail to mime@docserver.cac.washington.edu for more info.
>
> ---559023410-1836660416-1092366778=:20690
> Content-Type: TEXT/PLAIN; charset=US-ASCII
>
> Hello,
>
> The 'load-subs' command prints out "Subscribed to messages from file" even
> if the file doesn't exist. In owl_zephyr_loadsubs() in zephyr.c, 0 was
> being returned if stat failed, instead of -1. Here's a patch that fixes
> this.
>
> Arun
> ---559023410-1836660416-1092366778=:20690
> Content-Type: TEXT/PLAIN; charset=US-ASCII; name="owl.loadsubsfix"
> Content-ID: <Pine.GSO.4.55L.0408122312580.20690@multics.mit.edu>
> Content-Description:
> Content-Disposition: attachment; filename="owl.loadsubsfix"
> Content-Transfer-Encoding: BASE64
>
> SW5kZXg6IHplcGh5ci5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
> PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg
> ZmlsZTogL21pdC9rdG9vbHMvc3JjL293bC9yZXBvc2l0b3J5L293bC96ZXBo
> eXIuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDcNCmRpZmYgLXUgLXUg
> LXIxLjQ3IHplcGh5ci5jDQotLS0gemVwaHlyLmMJMTggQXByIDIwMDQgMTU6
> NTU6NDIgLTAwMDAJMS40Nw0KKysrIHplcGh5ci5jCTEzIEF1ZyAyMDA0IDAz
> OjA5OjA0IC0wMDAwDQpAQCAtODcsNyArODcsNyBAQA0KICAgfQ0KIA0KICAg
> cmV0PXN0YXQoc3Vic2ZpbGUsICZzdGF0YnVmZik7DQotICBpZiAocmV0KSBy
> ZXR1cm4oMCk7DQorICBpZiAocmV0KSByZXR1cm4oLTEpOw0KIA0KICAgcmV0
> PTA7DQogDQo=
>
> ---559023410-1836660416-1092366778=:20690--
> --[0347]-- (flagged)
>
