[612] in Zephyr_Bugs

home help back first fref pref prev next nref lref last post

Re: zephyr server crashing due to memory error

daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Jul 6 15:28:12 1995

Date: Thu, 6 Jul 1995 15:29:49 -0400
From: Greg Hudson <ghudson@MIT.EDU>
To: "E. Jay Berkenbilt" <ejb@ERA.COM>
Cc: bug-zephyr@MIT.EDU
In-Reply-To: "[606] in Zephyr_Bugs"


Thanks for the patch.  However, I think the real problem (which I also
found using Purify, but could have found using "lint") comes when you
cancel your subscriptions.  I've included a patch to class.c to fix
the problem.  (I've also added a prototype to zserver.h to prevent
ZDest_eq() type errors in the future, but you don't need that).

***************
*** 151,157 ****
  #endif
      hashval = DEST_HASHVAL(*dest);
      for (triplet = triplet_bucket[hashval]; triplet; triplet = triplet->next) {
!       if (ZDest_eq(triplet->dest, client)) {
            retval = remove_client(triplet, client);
            if (retval != ZERR_NONE)
                return retval;
--- 151,157 ----
  #endif
      hashval = DEST_HASHVAL(*dest);
      for (triplet = triplet_bucket[hashval]; triplet; triplet = triplet->next) {
!       if (ZDest_eq(triplet->dest, dest)) {
            retval = remove_client(triplet, client);
            if (retval != ZERR_NONE)
                return retval;

home help back first fref pref prev next nref lref last post